Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

176 messaging disclaimer #177

Merged
merged 2 commits into from
Mar 8, 2023
Merged

176 messaging disclaimer #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77e7157
add a disclaimer on the messages modal
alishaevn Mar 6, 2023
12f803f
use the "small" html tag and reduce line height
alishaevn Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/compounds/ActionsGroup/actions/SendMessage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ const SendMessage = ({ backgroundColor, onSubmit, handleClose }) => {
</ListGroup>
</Modal.Body>
<Modal.Footer>
<p className='fw-light fst-italic disclaimer'>
Please note that Supplier pricing and other information marked confidential by Supplier must be treated as such.
</p>

<p className='fw-light fst-italic disclaimer'>
Do not include any Sensitive Personal Data (e.g. data consisting of racial or ethnic origin, political opinions, religious or
philosophical beliefs, or trade union membership, genetic data, biometric data, data concerning health or data concerning a
natural person's sex life or sexual orientation) or potentially regulated information in messages or attachments.
</p>
<Button variant='primary' onClick={handleSubmit} type='submit'>
Send
</Button>
Expand Down
4 changes: 4 additions & 0 deletions src/compounds/ActionsGroup/actions/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@
#send-message {
height: 150px;
}

.disclaimer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you didn't want to add a whole custom style for this, you could just use the class of "small" here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I'll take another quick look at it tomorrow. I tried using fs-6 but it wasn't small enough.

Copy link
Contributor

@summer-cook summer-cook Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally (or in place of the class, if the size is small enough) it can be inside of <small></small> html tags for accessibility since these denote to screen readers that its a disclaimer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I added the small tags, but the text was still larger than desired with that alone. so I'm keeping the class and tag for styling plus accessibility. thanks for the note!

ref: mdn docs

font-size: 11px;
}