176 messaging disclaimer #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
summer-cook
approved these changes
Mar 7, 2023
summer-cook
reviewed
Mar 7, 2023
| @@ -4,3 +4,7 @@ | |||
| #send-message { | |||
| height: 150px; | |||
| } | |||
|
|
|||
| .disclaimer { | |||
There was a problem hiding this comment.
if you didn't want to add a whole custom style for this, you could just use the class of "small" here
There was a problem hiding this comment.
thanks! I'll take another quick look at it tomorrow. I tried using fs-6 but it wasn't small enough.
There was a problem hiding this comment.
additionally (or in place of the class, if the size is small enough) it can be inside of <small></small> html tags for accessibility since these denote to screen readers that its a disclaimer
There was a problem hiding this comment.
nice! I added the small tags, but the text was still larger than desired with that alone. so I'm keeping the class and tag for styling plus accessibility. thanks for the note!
ref: mdn docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story
when sending messages to the supplier, there should be a disclaimer
expected behavior
demo