Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 9 OpenScenario XML rules #27

Merged
merged 15 commits into from
Jul 18, 2024
Merged

Add 9 OpenScenario XML rules #27

merged 15 commits into from
Jul 18, 2024

Conversation

hoangtungdinh
Copy link
Contributor

This PR is built on top of #19 and it carries commits from #19.

Description

This PR adds the implementation of OpenScenario XML rules. A total of 9 rules have been implemented so far.

Main changes

  1. Implement OpenScenario XML rules.

How was the PR tested?

  1. Tests are documented in the PR above.

Notes

9 implemented rules

romanodanilo and others added 15 commits June 12, 2024 10:49
@romanodanilo
Move old implementation to specific folder (#3)
b75a672 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo
Add first version with new running checker (#4)
c1f0c35 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo
Add CI/CD (#5)
f5e82c3 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo
Add valid schema checker (#6)
8301f81 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo
Support schema v1.1.0 and v1.2.0 (#7)
4c4726f 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@hoangtungdinh
Rename the first two rules (#10)
8cae879 
Signed-off-by: hoangtungdinh <[email protected]>

Signed-off-by: hoangtungdinh <[email protected]>
@hoangtungdinh
Remove the original implementation (#12)
fc25eac 
Signed-off-by: hoangtungdinh <[email protected]>
@romanodanilo @hoangtungdinh
Add unique name checks and tests (#11)
489869c 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Add resolve checks for traffic sign and controller (#20)
1cc3885 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Add valid actor reference in private actions check (#21)
d9bbf7a 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Add resolvable checks implementation (#22)
27aa046 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Add valid parameter check declaration (#23)
e921079 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Fix parametric input xodr specification (#24)
039b18b 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Fix parametric entity references (#25)
26473d4 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@romanodanilo @hoangtungdinh
Add get attribute type function in utils (#26)
7d43e32 
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Jul 11, 2024
This was referenced Jul 11, 2024
Closed
Closed
@andreaskern74 andreaskern74 added isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager and removed isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Jul 18, 2024
pmai
pmai approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-07-18: Merge as-is.

@pmai pmai merged commit 5a0a1a3 into main Jul 18, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the 2024-07-11 branch July 30, 2024 10:39
@andreaskern74 andreaskern74 added isState:Integrated An issue that has been integrated and has an integration reviewer and removed isState:ReadyForMerge An issue that has been integrated and is assigned to the workflow manager labels Aug 22, 2024
@andreaskern74 andreaskern74 removed the isState:Integrated An issue that has been integrated and has an integration reviewer label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoangtungdinh @pmai @andreaskern74 @romanodanilo