Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI/CD and implement the first two rules #9

Closed
wants to merge 7 commits into from
Closed

Conversation

hoangtungdinh
Copy link
Contributor

@hoangtungdinh hoangtungdinh commented Jun 18, 2024

Description

This PR is ready for CCB's review.

This PR sets up the structure of the repository, creates CI/CD and implements the first two rules using the Python Base Library.

Main changes

  1. The original implementation is moved to the original_implementation folder so that it can still be easily accessed and used as the reference implementation for the new rules. Towards the end of the project, the folder original_implementation will be removed.
  2. Add CI/CD
  3. Implement two rules: xml.valid_xml_document and xml.valid_schema

How was the PR tested?

  1. Tests are documented in each PR above.

Notes

This PR will close the following issues:

Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
@hoangtungdinh hoangtungdinh added the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Jun 18, 2024
Signed-off-by: hoangtungdinh <[email protected]>

Signed-off-by: hoangtungdinh <[email protected]>
Copy link
Collaborator

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me.

Other than that only the same question as for opendrive, i.e. why not just remove to original implementation?

@hoangtungdinh
Copy link
Contributor Author

@pmai, the reason we keep the original implementation is that it is easier to access and use as a reference when implementing the rule, as we don't have to search the commit history or another branch to find the original implementation. However, I can see that it causes confusion. We will remove the original implementation in the next sprint.

@hoangtungdinh
Copy link
Contributor Author

I am closing this PR as we now have #27 carrying all the commits from this PR.

@andreaskern74 andreaskern74 removed the isState:ForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok label Jul 18, 2024
@hoangtungdinh hoangtungdinh deleted the 2024-06-18 branch July 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants