-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safeguard unit test threading #285
Conversation
0c8c5d7
to
782ac6e
Compare
@caguilar187 Let me know how you feel about that latest change. |
As requested offline by @caguilar187, I am running the full CircleCI integration multiple times against commit 782ac6e. If it passes 70+% of these runs, we will consider this a sufficiently-worthwhile improvement and thus worthy of being merged in. |
We're looking at 50% success after 8 runs.....breakdown of failures as follows: 2 failures due to the daemon disappearing (tasks I personally believe all but the 'integer number too large' failure are affected by the memory allocated during compilation, especially of those modules running kapt. If we reduced the associated load by e.g. consolidating modules (as in #299) or re-evaluating the complexity of some of our database objects, I'm sure the failure rate would decrease as well. I'll now take the opportunity to rebase this branch on the latest @caguilar187 your thoughts? |
782ac6e
to
8ccd227
Compare
I'll rebase on |
4551688
to
f6b7132
Compare
Supposedly Gradle doesn't read JVM_OPTS, and instead prefers JAVA_OPTS
f6b7132
to
03f2033
Compare
We've reached 7/8 successes for this last commit. |
Ideally, this will remove some flakiness from our tests in
AppDataManagerTest.kt
.Said uncertainty was introduced by 9d41f30.
This PR also reduces the memory usage of the JVM build process (advice derived from https://discuss.circleci.com/t/circleci-2-0-android-with-kotlin/17531/2 ) and switches the version of the Android Gradle Plugin in use to the latest stable release (v3.2.1).