Update gradle dependencies for October 2018 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caguilar187
reviewed
Oct 27, 2018
build.gradle
Outdated
| @@ -106,6 +106,10 @@ subprojects { | |||
| apply plugin: 'com.android.library' | |||
| } | |||
| apply plugin: 'kotlin-android' | |||
| if (name != 'analytics' && name != 'image') { | |||
| // Most modules make use of the synthetic accessors; ':db' uses the experimental 'Parcelize' annotation, so it does some configuration beyond that. | |||
| apply plugin: 'kotlin-android-extensions' | |||
There was a problem hiding this comment.
i know these two don't need it but is there harm in applying them? looking at this from a simplification stand point
There was a problem hiding this comment.
Slightly, yes. Since I'm
- trying to avoid changing functionality here
- still not confident I know precisely what the plugin does
I scheduled that for a subsequent PR. For a point of reference, the first time you apply the kapt plugin to a module you add at least .5 seconds to the configuration time.
There was a problem hiding this comment.
...you're not going to take no for an answer, are you?
|
I'll rebase on dev and add a few commits I forgot to push up. |
Cliabhach
force-pushed
the
pc-update-gradle-dependencies-october-2018
branch
from
3ab43aa to
471f10a
Compare
As it stands, 24 out of 27 build.gradle files apply that.
This reduces most gradle files to just a list of dependencies
This moves all such statements in search/build.gradle to be in a single block.
This also splits the `implementation` and `api` statements in the ui/build.gradle file.
In addition to sorting those entries in welcome/build.gradle, we now only have one `implementation libs.constraint_layout` declaration.
This intends to put more emphasis on the
`implementation project(':base')` line in navigation/build.gradle.
Cliabhach
force-pushed
the
pc-update-gradle-dependencies-october-2018
branch
from
471f10a to
f4ba0df
Compare
sam33rdhakal
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in what will hopefully be a series of regular maintenance changesets. This deals primarily with standardizing the 27
build.gradlefiles currently included in the repository.While the functionality of output APKs should not be different, with any luck these changes will shed some light onto our ongoing build instability. Specific fixes for that issue are being developed at #285.
Included in this PR:
apply plugin: Xlines from 26build.gradlefilescom.android.library(x1)kotlin-android(x2)kotlin-android-extensions(x24)kotlin-kapt(x25)kotlin-android-extensionswas not applied by the rootbuild.gradle, so that had to be done as welldependenciesblocks, with three primary goals