Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded helm chart version #561

Merged
merged 1 commit into from
Jan 6, 2025
Merged

hardcoded helm chart version #561

merged 1 commit into from
Jan 6, 2025

Conversation

amirmalka
Copy link
Contributor

@amirmalka amirmalka commented Jan 6, 2025

PR Type

Enhancement, Tests


Description

  • Hardcoded helm chart version added for specific test case.

  • Introduced helm_branch parameter for test configuration.

  • Updated logging to reflect helm branch usage in tests.

  • Added comments to clarify test deprecation conditions.


Changes walkthrough 📝

Relevant files
Tests
vuln_scan_tests.py
Hardcoded helm chart version for test case                             

configurations/system/tests_cases/vuln_scan_tests.py

  • Added a hardcoded helm chart version for a test case.
  • Included comments explaining test deprecation conditions.
  • +4/-0     
    Enhancement
    vuln_scan.py
    Introduced `helm_branch` parameter and updated logging     

    tests_scripts/helm/vuln_scan.py

  • Added helm_branch parameter to test configuration.
  • Updated logging to reflect helm branch usage.
  • +5/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Order

    The setup_helm_chart() call was moved before accessing its return values but there's no error handling if it fails. Consider adding try/catch block.

    cluster, namespace = self.setup_helm_chart() # TODO AMIR
    secret_data, registry = self.setup_phase(cluster, namespace)
    TODO Comment

    There is a TODO comment with assignee that should be addressed before merging the PR.

    cluster, namespace = self.setup_helm_chart() # TODO AMIR

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    github-actions bot commented Jan 6, 2025

    Failed to generate code suggestions for PR

    @amirmalka amirmalka merged commit ddfeb39 into master Jan 6, 2025
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants