Skip to content

Commit

Permalink
hardcoded helm chart version
Browse files Browse the repository at this point in the history
Signed-off-by: Amir Malka <[email protected]>
  • Loading branch information
amirmalka committed Jan 6, 2025
1 parent a705a2c commit 17bac51
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions configurations/system/tests_cases/vuln_scan_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ def vuln_scan_trigger_scan_public_registry_excluded():
return TestConfiguration(
name=inspect.currentframe().f_code.co_name,
test_obj=VulnerabilityScanningRegistry,

# This test is forced to use version 1.24.2 of the helm chart since this is the last version which supports the old registry scan API
# Please remove this test once the BE will stop supporting this functionality')
helm_branch="kubescape-operator-1.24.2",
deployment=join(DEFAULT_DEPLOYMENT_PATH, "public-registry.yaml"),
service=join(DEFAULT_SERVICE_PATH, "public-registry.yaml"),
properties={'http': True}, # https://hub.armosec.io/docs/registry-vulnerability-scan
Expand Down
6 changes: 5 additions & 1 deletion tests_scripts/helm/vuln_scan.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,12 @@ def setup_phase(self, cluster, namespace):
return secret_data, registry

def start(self):
helm_branch = self.test_obj.kwargs['helm_branch'] if 'helm_branch' in self.test_obj.kwargs else None
if helm_branch and helm_branch != "":
Logger.logger.info(f'using helm branch from test definition: {helm_branch}')
self.helm_branch = helm_branch

cluster, namespace = self.setup_helm_chart()
cluster, namespace = self.setup_helm_chart() # TODO AMIR
secret_data, registry = self.setup_phase(cluster, namespace)

# trigger scanning of an image from a registry
Expand Down

0 comments on commit 17bac51

Please sign in to comment.