Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded helm chart version #561

Merged
merged 1 commit into from
Jan 6, 2025
Merged

hardcoded helm chart version #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions configurations/system/tests_cases/vuln_scan_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ def vuln_scan_trigger_scan_public_registry_excluded():
return TestConfiguration(
name=inspect.currentframe().f_code.co_name,
test_obj=VulnerabilityScanningRegistry,

# This test is forced to use version 1.24.2 of the helm chart since this is the last version which supports the old registry scan API
# Please remove this test once the BE will stop supporting this functionality')
helm_branch="kubescape-operator-1.24.2",
deployment=join(DEFAULT_DEPLOYMENT_PATH, "public-registry.yaml"),
service=join(DEFAULT_SERVICE_PATH, "public-registry.yaml"),
properties={'http': True}, # https://hub.armosec.io/docs/registry-vulnerability-scan
Expand Down
4 changes: 4 additions & 0 deletions tests_scripts/helm/vuln_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,10 @@ def setup_phase(self, cluster, namespace):
return secret_data, registry

def start(self):
helm_branch = self.test_obj.kwargs['helm_branch'] if 'helm_branch' in self.test_obj.kwargs else None
if helm_branch and helm_branch != "":
Logger.logger.info(f'using helm branch from test definition: {helm_branch}')
self.helm_branch = helm_branch

cluster, namespace = self.setup_helm_chart()
secret_data, registry = self.setup_phase(cluster, namespace)
Expand Down
Loading