fix(scannercli): Pass temporary robot account credentials to scannercli #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass Robot Account credentials generated by Harbor for each scan request through to the scannercli command as --registry-username and --registry-password flags. This feature is enabled by setting the value of the SCANNER_CLI_OVERRIDE_REGISTRY_CREDENTIALS to true. It has to be enable explicitly as not every version of scannercli accepts the --registry-username and --registry-password flags. Resolves: #37 Signed-off-by: Daniel Pacak <[email protected]>
Signed-off-by: Simarpreet Singh <[email protected]>
danielpacak
added
the
do not merge
|
Before merging we have to wait for the new release of scannercli , which supports Also we'll have to explain that only newer versions of Aqua / scannercli do support Harbor with deployment security enabled. /cc @simar7 |
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 40.55% 45.43% +4.88%
==========================================
Files 15 15
Lines 503 548 +45
==========================================
+ Hits 204 249 +45
Misses 293 293
Partials 6 6
Continue to review full report at Codecov.
|
danielpacak
removed
the
do not merge
Signed-off-by: Daniel Pacak <[email protected]>
danielpacak
added a commit
that referenced
this pull request
Jun 5, 2020
…li (#50) Pass Robot Account credentials generated by Harbor for each scan request through to the scannercli command as --robot-username and --robot-password flags. This feature is enabled by setting the value of the SCANNER_CLI_OVERRIDE_REGISTRY_CREDENTIALS to true. It has to be enable explicitly as not every version of scannercli accepts the --robot-username and --robot-password flags. Resolves: #37 Co-authored-by: Simarpreet Singh <[email protected]> Signed-off-by: Daniel Pacak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #37
Signed-off-by: Daniel Pacak [email protected]