-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harbor integration fails when deployment security is enabled #37
Comments
Hi @rvennam-lbg . Thank you for filing the issue. As you pointed out this is related to robot account permissions and the I'm working also with the product team at Aqua to pass the robot account credentials from
As of today, the only solution to that is, unfortunately, disabling deployment security in Harbor. |
Thanks @danielpacak, can you kindly suggest if any help is required to expedite implementation, as we have a key requirement on this feature within our container workflow. |
@honeybajaj There're two parts of it:
|
@danielpacak One more feature request or it might automatically get enabled is integration with acknowledge feature on Aqua. So, if an admin or security engineer acknowledge a vulnerability for an image in Aqua, will Harbor understands that and allow an image to run. |
Yes. That's a great feedback @honeybajaj We'll take that into account and follow up. |
@danielpacak Do you have a view on when this feature will become available for consumption/testing. Thanks for all your help. |
@honeybajaj We have a PR ready with the fix in the adapter service waiting for review #50 - I believe we can merge it soon. However, in order to test it with Harbor we have to wait for the Aqua release train. I will let you know as soon as I get possible release date from the product team. They're heads down adding new flags to scannercli, i.e. |
…li (#50) Pass Robot Account credentials generated by Harbor for each scan request through to the scannercli command as --registry-username and --registry-password flags. This feature is enabled by setting the value of the SCANNER_CLI_OVERRIDE_REGISTRY_CREDENTIALS to true. It has to be enable explicitly as not every version of scannercli accepts the --registry-username and --registry-password flags. Resolves: #37 Co-authored-by: Simarpreet Singh <[email protected]> Signed-off-by: Daniel Pacak <[email protected]>
@honeybajaj I've tested the code with a dev build version of Aqua CSP. Everything works as expected. I'll close this issue shortly once we have the official release and exact version number. |
@honeybajaj @rvennam-lbg If this adapter service is used with Aqua version >= 4.6.20181 (4.6 update 16), it can bypass Harbor's deployment security proxy. For more details consult https://github.com/aquasecurity/harbor-scanner-aqua#error-failed-getting-image-manifest-412-precondition-failed |
This is linked to the issue opened at goharbor/harbor#11574 where we are seeing the same behaviour with interrogation services configured with Aqua are also failing to pull the images to scan.
Is there any specific configuration to be used to the deployment to be still able to pull the images for scanning?
The text was updated successfully, but these errors were encountered: