Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Make forceUnmap protected since the only test class that references it is in the same package now. #18638

Merged
merged 3 commits into from
Jan 23, 2025
Merged

MINOR: Make forceUnmap protected since the only test class that references it is in the same package now. #18638

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67166ee
Make forceUnmap protected
pramithas Jan 20, 2025
43fd04b
Update commit message
pramithas Jan 20, 2025
71361c1
Update comment as per convention
pramithas Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,8 @@ protected void safeForceUnmap() {
/**
* Forcefully free the buffer's mmap.
*/
// Visible for testing, we can make this protected once OffsetIndexTest is in the same package as this class
public void forceUnmap() throws IOException {
// Visible for testing
protected void forceUnmap() throws IOException {
try {
ByteBufferUnmapper.unmap(file.getAbsolutePath(), mmap);
} finally {
Expand Down
Loading