MINOR: Make forceUnmap protected since the only test class that references it is in the same package now.
#18638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramithas
changed the title
forceUnmap protected since the only test class that references it is in the same package now.
github-actions
bot
added
triage
pramithas
changed the title
forceUnmap protected since the only test class that references it is in the same package now.forceUnmap protected since the only test class that references it is in the same package now.
|
@divijvaidya Can you please review this? |
divijvaidya
reviewed
Jan 21, 2025
| @@ -399,8 +399,8 @@ protected void safeForceUnmap() { | |||
| /** | |||
| * Forcefully free the buffer's mmap. | |||
| */ | |||
| // Visible for testing, we can make this protected once OffsetIndexTest is in the same package as this class | |||
| public void forceUnmap() throws IOException { | |||
| // Made protected for the sake of visibility for testing. | |||
There was a problem hiding this comment.
nit
we usually use //visible for testing comment for this in the code base. But it's ok to do it this way as well in this PR. Doesn't matter as long as the intent is conveyed.
There was a problem hiding this comment.
Thank you for the feedback. I have updated the comment. Could you please re-trigger the build?
divijvaidya
approved these changes
Jan 21, 2025
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Divij Vaidya <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Divij Vaidya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
forceUnmapmethod was made public for the sake of visibility for testing since the test classOffsetIndexTestwas in a different package before. Now, the test class is in the same package, so that method can been madeprotected.The sole usage of this method is inside the class that it is defined in:
AbstractIndexand the test class:OffsetIndexTestCommitter Checklist (excluded from commit message)