fix: remove redundant name attribute from logging plugins

[kayx23]

Description

Unique ID for batch processor (attribute name) are hardcoded in for quite many logging plugins. The docs, schema of certain plugins, and tests, previously treat name as a configurable attribute, which could create confusions, such as #10474.

Checklist

• I have explained the need for this PR and the problem it solves
• I have explained the changes or the new features added to this PR
• I have added tests corresponding to this change
• I have updated the documentation to reflect this change
• I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

[kayx23]

Lmk if I should apply this change for other plugins in the same PR. Quite a few logging plugins have the same issues if I'm not mistaken.

[moonming]

Lmk if I should apply this change for other plugins in the same PR. Quite a few logging plugins have the same issues if I'm not mistaken.

yes, please do it

[pottekkat]

LGTM and +1 to go ahead and fix this in other plugins as well.

[kayx23]

Just saw in clickhouse-logger and sys-logger the namea are indeed configurable:

apisix/apisix/plugins/clickhouse-logger.lua

Lines 28 to 41 in d8bd344

	local batch_processor_manager = bp_manager_mod.new(plugin_name)
	local schema = {
	type = "object",
	properties = {
	-- deprecated, use "endpoint_addrs" instead
	endpoint_addr = core.schema.uri_def,
	endpoint_addrs = {items = core.schema.uri_def, type = "array", minItems = 1},
	user = {type = "string", default = ""},
	password = {type = "string", default = ""},
	database = {type = "string", default = ""},
	logtable = {type = "string", default = ""},
	timeout = {type = "integer", minimum = 1, default = 3},
	name = {type = "string", default = "clickhouse logger"},

Are we going to:

1. make the other logger plugin names configurable as well;
2. update clickhouse logger and sys logger to be consistent with others, which hard code the name; or
3. Just update the docs for those that are not configurable (done)?

[moonming]

Just saw in clickhouse-logger and sys-logger the namea are indeed configurable:

apisix/apisix/plugins/clickhouse-logger.lua

Lines 28 to 41 in d8bd344

	local batch_processor_manager = bp_manager_mod.new(plugin_name)
	local schema = {
	type = "object",
	properties = {
	-- deprecated, use "endpoint_addrs" instead
	endpoint_addr = core.schema.uri_def,
	endpoint_addrs = {items = core.schema.uri_def, type = "array", minItems = 1},
	user = {type = "string", default = ""},
	password = {type = "string", default = ""},
	database = {type = "string", default = ""},
	logtable = {type = "string", default = ""},
	timeout = {type = "integer", minimum = 1, default = 3},
	name = {type = "string", default = "clickhouse logger"},

Are we going to:

1. make the other logger plugin names configurable as well;
2. update clickhouse logger and sys logger to be consistent with others, which hard code the name; or
3. Just update the docs for those that are not configurable (done)?

Option 2 is the clear choice for me

[kayx23]

Ok as it turns out (thanks to the failed CI tests) that this name attribute is actually configurable and its value gets exported to prometheus to identify batch processors.

The reason why the name attribute was documented to each of these logging plugin, despite being a batch processor attribute, was likely because these loggers initiate batch processor instances with specific names (the hard coded values), so they are the default values specific to these plugins.

In short, these docs should not be removed and the documented default values are consistent with what goes in the code.