Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(syslog): remove the unused property name #10644

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jujiale
Copy link
Contributor

@jujiale jujiale commented Dec 13, 2023

Description

in pr #5763 , the syslog property name have been deleted, but in doc, it exists, so we should delete it.

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Copy link
Member

@moonming moonming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jujiale good catch👍

@monkeyDluffy6017 monkeyDluffy6017 changed the title chore(syslog): remove the unused property name docs(syslog): remove the unused property name Dec 13, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 0609efa into apache:master Dec 13, 2023
9 checks passed
@kayx23
Copy link
Member

kayx23 commented Dec 14, 2023

In my past tests with other logger plugins, the name is actually configurable and gets exported to prometheus apisix_batch_process_entries metric.

image

https://github.com/search?q=repo%3Aapache%2Fapisix+sys-logger&type=code

You can change "name": "sys-logger" to a different value and see if test will pass, to verify if the field is actually configurable.

jujiale added a commit to jujiale/apisix that referenced this pull request Dec 14, 2023
@jujiale
Copy link
Contributor Author

jujiale commented Dec 14, 2023

In my past tests with other logger plugins, the name is actually configurable and gets exported to prometheus apisix_batch_process_entries metric.

image

https://github.com/search?q=repo%3Aapache%2Fapisix+sys-logger&type=code

You can change "name": "sys-logger" to a different value and see if test will pass, to verify if the field is actually configurable.

I checked it. it's my negligence, I have created a new pr to revert it. thanks a lot

kayx23 pushed a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants