Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed Launcher.launch_sherlock() to properly append sherlock_command_args #487

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

ansjmoody
Copy link
Collaborator

Description

Modify Launcher.launch_sherlock() to add sherlock_command_args to the list of arguments. It was appending the string representation of the list to the arguments.

Issue linked

Closes #453

Checklist:

  • [] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • [] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running
  • [] Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansjmoody ansjmoody added this to the v0.9.0 milestone Jan 17, 2025
@ansjmoody ansjmoody requested a review from anskhanson January 17, 2025 21:46
@ansjmoody ansjmoody self-assigned this Jan 17, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.07%. Comparing base (6227ba1) to head (7f501d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/launcher.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   60.07%   60.07%           
=======================================
  Files          21       21           
  Lines        5009     5009           
=======================================
  Hits         3009     3009           
  Misses       2000     2000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjmoody ansjmoody merged commit 85a6193 into main Jan 20, 2025
30 of 31 checks passed
@ansjmoody ansjmoody deleted the jeff/fix_launcher_command_args branch January 20, 2025 20:44
ansjmoody added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use sherlock_cmd_args when using launch_sherlock() in launcher.py
3 participants