fix: changed Launcher.launch_sherlock() to properly append sherlock_c…

…ommand_args (#487) Co-authored-by: pyansys-ci-bot <[email protected]>
ansys · Jan 20, 2025 · 85a6193 · 85a6193
1 parent 6227ba1
commit 85a6193
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/doc/changelog.d/487.documentation.md b/doc/changelog.d/487.documentation.md
@@ -0,0 +1 @@
+fix: changed Launcher.launch_sherlock() to properly append sherlock_command_args
diff --git a/src/ansys/sherlock/core/launcher.py b/src/ansys/sherlock/core/launcher.py
@@ -82,7 +82,7 @@ def launch_sherlock(
     try:
         _is_port_available(host, port)
     except Exception as e:
-        print(str(e))
+        LOG.error(str(e))
         raise e
 
     _server_version = None
@@ -95,8 +95,8 @@ def launch_sherlock(
             args.append("-singleProject")
             args.append(single_project_path)
         if sherlock_command_args != "":
-            args.append(f"{shlex.split(sherlock_command_args)}")
-        print(args)
+            args.extend(shlex.split(sherlock_command_args))
+        LOG.info(f"Command arguments: {args}")
         subprocess.Popen(args)
 
         sherlock = connect_grpc_channel(port, _server_version)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		fix: changed Launcher.launch_sherlock() to properly append sherlock_command_args