Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Refactor grpc plugin #4719

Merged
merged 10 commits into from
May 24, 2024
Merged

REFACTOR: Refactor grpc plugin #4719

merged 10 commits into from
May 24, 2024

Conversation

maxcapodi78
Copy link
Collaborator

Full support to multidesktop (windows/linux)

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@maxcapodi78 maxcapodi78 changed the title Refactor grpc plugin REFACT: Refactor grpc plugin May 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 72.15569% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 80.43%. Comparing base (34c5e21) to head (80bd8c4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4719      +/-   ##
==========================================
- Coverage   80.48%   80.43%   -0.06%     
==========================================
  Files         122      121       -1     
  Lines       54964    55116     +152     
==========================================
+ Hits        44240    44331      +91     
- Misses      10724    10785      +61     

@maxcapodi78 maxcapodi78 changed the title REFACT: Refactor grpc plugin REFACTOR: Refactor grpc plugin May 23, 2024
pyaedt/desktop.py Outdated Show resolved Hide resolved
@maxcapodi78 maxcapodi78 removed the request for review from Alberto-DM May 24, 2024 12:56
@maxcapodi78 maxcapodi78 enabled auto-merge (squash) May 24, 2024 12:58
@maxcapodi78 maxcapodi78 merged commit 4c4932b into main May 24, 2024
32 of 33 checks passed
@maxcapodi78 maxcapodi78 deleted the refactor_grpc_plugin branch May 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants