Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all tests #269

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Fix all tests #269

merged 5 commits into from
Jun 13, 2022

Conversation

TomasTomecek
Copy link
Collaborator

@TomasTomecek TomasTomecek commented Mar 31, 2022 •
edited
Loading

TODO:

  • fix all test failures:
    • fix test_build_basic_image_with_all_params test
    • tests/integration/test_api.py::test_build_db_metadata
    • tests/functional/test_cli.py::test_get_logs
    • tests/functional/test_buildah.py::test_build_failure
    • tests/functional/test_buildah.py::test_build_basic_image_with_build_volumes

also has:

callback_whitelist is deprecated

so let's set both to be backwards compatible and drop callback_whitelist
once 2.15 is out

@themkat themkat mentioned this pull request Apr 6, 2022
Merged
@themkat
Copy link
Contributor

themkat commented May 6, 2022

Any progress here? 🙂 Seems like one test is fixed and works like a charm now. Would be super nice to be able to get a clean green build on future PRs 😄

@TomasTomecek
Copy link
Collaborator Author

@themkat completely agree. Sadly I'm swamped with tasks in my work and my personal life. I hope it will be better over the next weeks so I can get back to this and make CI 🟢. No promises though :|

@TomasTomecek
Copy link
Collaborator Author

2 weeks and I'm still busy with my main job (and my personal life), I hope things get easier in the Summer

@TomasTomecek TomasTomecek reopened this Jun 6, 2022
@TomasTomecek
callback_whitelist is deprecated
cfd2604 
so let's set both to be backwards compatible and drop callback_whitelist
once 2.15 is out

Signed-off-by: Tomas Tomecek <[email protected]>
@TomasTomecek
fix test test_build_basic_image_with_all_params
d9ee56a 
the upstream image has now more labels by default, so let's check for
presence of the one we are adding

Signed-off-by: Tomas Tomecek <[email protected]>
@TomasTomecek
fix tests broken by a deprecation warning
82d2b5e 
The string starts with a deprecation warning, so let's check for
presence of the PLAY in the logs.

Signed-off-by: Tomas Tomecek <[email protected]>
@TomasTomecek
fix test test_build_basic_image_with_build_volumes
7dc4587 
Had to add :Z, SELinux

Signed-off-by: Tomas Tomecek <[email protected]>
@TomasTomecek TomasTomecek mentioned this pull request Jun 9, 2022
Closed
@TomasTomecek
Copy link
Collaborator Author

@themkat I finally have time to resolve this! Would you please have time to review my PR?

@TomasTomecek TomasTomecek mentioned this pull request Jun 9, 2022
Closed
themkat
themkat approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@themkat themkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 😄 Squash looks useful

ansible_bender/core.py
@@ -55,12 +55,16 @@
is_ansibles_python_2

logger = logging.getLogger(__name__)
# callback_whitelist got renamed to callbacks_enabled in ansible
# drop callback_whitelist once 2.15 is released
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a task/issue for this? Could be useful, as at least I, often forget notes like this in the source code 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point! #272

@TomasTomecek TomasTomecek mentioned this pull request Jun 9, 2022
Open
@TomasTomecek
Copy link
Collaborator Author

/packit test

@TomasTomecek
Copy link
Collaborator Author

/packit retest-failed

@TomasTomecek
Copy link
Collaborator Author

36 and rawhide tests passed, merging

35 bit by #274

@TomasTomecek TomasTomecek merged commit cf6b517 into ansible-community:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themkat themkat themkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasTomecek @themkat