Remove Docker hub dependency in tests #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #244. Docker hub has a pull quota for images, about 100 in 6 hours. This can cause tests to fail. Experienced it locally when I got acquainted with the source code (modifying code, running tests, deleting images, rinse and repeat 😛 ). Unsure if the tests run on the same machines with the same IPs in CI, but it could in theory happen there as well.
Believe this, combined with the PR @TomasTomecek is currently doing, #269, will make contributions more pleasant 🙂 Green pipeline and zero random Docker hub related issues are a good thing after all.
Criteria used to select replacement images (all from Quay.io):