-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improved error message clarity #38
Conversation
19da0c7
to
c0850f1
Compare
c0850f1
to
bcc9587
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more a feat than a fix.
I think the implementation can be simpler. Maybe we should redesign the error management within the entire cli.
I've tested it (actually used it for all of the following PRs) and it seems to work. The implementation could be simpler for sure, the added |
Also, I labeled this as a fix because when the changelog gets generated it makes more sense for the end user "fix: Improved error message clarity". From their prespective it's a fix. |
8f5806d
to
650971d
Compare
650971d
to
dbf02f0
Compare
dbf02f0
to
cc6efe7
Compare
Motivation
The error handler would capture all error messages and obfuscate them.
Description
Rewrote the error handler so that it prints out the error details in a neater way (using click/rich_click) and such that the debug option allows you to view said error
Testing
Generated different gRPC errors and observed the error messages generated.
Impact
None.
Additional Information
None.
Checklist