Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: task create now returns a single task object #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AncientPatata
Copy link
Contributor

Motivation

task create would return a list with a single task object

Description

  • task create now returns a singular task object instead
  • changed test to work with the error handler (since it uses click exceptions, it doesn't close with a failing exit code)
  • changed the return type of reformat_cmd_output from str to Union[str, Dict[str, Any]]

Testing

Unit tests pass

Impact

Small improvements towards a better and more consistent tool.

Additional Information

This requires the changes from #38 for tests to pass

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant