-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize CMake #203
Modernize CMake #203
Conversation
73ff174
to
f7d3611
Compare
c53b07e
to
d5f5ec5
Compare
@psychocoderHPC Ready for review |
From the review in our developer meeting today:
|
d3a3256
to
cf3d5e3
Compare
@SimeonEhrig Do you tested this PR with nvcc as CUDA compiler too? I working on moving alpaka 0.7.0 to cupla and integrated your changes. When try to use cmake with CUDA I get
|
This error happens only with |
We can't ignore |
I played a little bit more with the error. If I install alpaka and use |
I tested the latest master branch from CMake, the issue still exists, therefore something else is wrong :-( |
b009451
to
8fb9461
Compare
- CMakeLists.txt can be included in Projects via add_subdirectory and find_package - add mechanism to extract version number from header file (copied from alpaka - thanks to Jan stephan) - add cuplaConfig.cmake and cuplaTargets.cmake - add CMake integration tests - build external project, which uses cupla via - add_subdirectory() and internal alpaka - add_subdirectory() and external alpaka - find_package() - add cmake option to build examples
8fb9461
to
18347db
Compare
We will not merge this PR directly, if #213 is merged this PR will be merged automatically. |
FWIW, in CMSSW we have been building cupla as a shared library, even though we are not using it in production yet. |
Good point. I opened an issue (#218 ) to address your comment. |
The CMake is completely modernized. The main targets are
find_package()
add_subdirectory()
more commonAddress issue #158
TODO
add_subdirectory
find_package()