fix alpaka_add_(executable|library)
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- activate language `CUDA` if CUDA back-end is enabled - fix missing argument in `SET_SOURCE_FILES_PROPERTIES`
j-stephan
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDAif CUDA back-end is enabledSET_SOURCE_FILES_PROPERTIESThis PR fix alpaka-group/cupla#203 (comment) due to the missing argument
PROPERTIESfiles were not handled as CUDA files.Additionally
alpaka_add_executableandalpaka_add_libraryare macros and will be executed in users application scope, therefore the cmake language CUDA must be loaded else the compiler can not give the files to the correct compiler.I will open a PR for the dev branch as soon as this is merged. There is no need to add this bug to the changelog because it is a bug introduced in 0.7.0 and not exists in 0.6.X.