Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize and improve scrollmsg.sma #579

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Modernize and improve scrollmsg.sma #579

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8e823bf
Apply line breaks
OciXCrom Sep 13, 2018
f6fc233
Apply semicolons
OciXCrom Sep 13, 2018
199daad
Add cvars
OciXCrom Sep 13, 2018
bfaa326
Add amx_scrollmsg_only_dead cvar
OciXCrom Sep 13, 2018
57ae073
Bind hostname cvar to global variable
OciXCrom Sep 13, 2018
2335f89
Add consts
OciXCrom Sep 13, 2018
aa44e57
Add srvcmd syntax
OciXCrom Sep 13, 2018
38cef18
Add frequency param in syntax
OciXCrom Sep 13, 2018
e96533b
Change variable names for consistency
OciXCrom Sep 13, 2018
a804a14
Change show_hudmessage to ShowSyncHudMsg
OciXCrom Sep 13, 2018
2e2aa7b
Use new functions
OciXCrom Sep 13, 2018
6531fb0
Add AutoExecConfig?
OciXCrom Sep 13, 2018
8b4c266
Add space after if/while
OciXCrom Sep 13, 2018
7ac1c39
Add spaces between flags
OciXCrom Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 95 additions & 53 deletions plugins/scrollmsg.sma
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,94 +14,136 @@
#include <amxmodx>
#include <amxmisc>

#define SPEED 0.3
#define SCROLLMSG_SIZE 512
const SCROLLMSG_SIZE = 512;
const SCROLLMSG_TASK = 123;

new g_startPos
new g_endPos
new g_scrollMsg[SCROLLMSG_SIZE]
new g_displayMsg[SCROLLMSG_SIZE]
new Float:g_xPos
new g_Length
new g_Frequency
new g_hostname[64];
new g_amx_scrollmsg_color_red;
new g_amx_scrollmsg_color_green;
new g_amx_scrollmsg_color_blue;
new g_amx_scrollmsg_only_dead;
new Float:g_amx_scrollmsg_speed;
new Float:g_amx_scrollmsg_x_move_amount;
new Float:g_amx_scrollmsg_x_start_pos;
new Float:g_amx_scrollmsg_x_end_pos;
new Float:g_amx_scrollmsg_y_pos;

new g_start_pos;
new g_end_pos;
new g_scroll_msg[SCROLLMSG_SIZE];
new g_display_msg[SCROLLMSG_SIZE];
new g_length;
new g_frequency;
new g_hud_object;
new Float:g_x_pos;

public plugin_init()
{
register_plugin("Scrolling Message", AMXX_VERSION_STR, "AMXX Dev Team")
register_dictionary("scrollmsg.txt")
register_dictionary("common.txt")
register_srvcmd("amx_scrollmsg", "setMessage")
register_plugin("Scrolling Message", AMXX_VERSION_STR, "AMXX Dev Team");

register_dictionary("scrollmsg.txt");
register_dictionary("common.txt");

register_srvcmd("amx_scrollmsg", "setMessage", _, "<message> <frequency>");
bind_pcvar_string(get_cvar_pointer("hostname"), g_hostname, charsmax(g_hostname));

bind_pcvar_num(create_cvar( "amx_scrollmsg_color_red", "200", _, "Red color amount", true, 0.0, true, 255.0), g_amx_scrollmsg_color_red);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to implode it to one cvar amx_scrollmsg_color 200 100 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure really, both seem fine to me. Let's hear more opinions.

bind_pcvar_num(create_cvar( "amx_scrollmsg_color_green", "100", _, "Green color amount", true, 0.0, true, 255.0), g_amx_scrollmsg_color_green);
bind_pcvar_num(create_cvar( "amx_scrollmsg_color_blue", "0", _, "Blue color amount", true, 0.0, true, 255.0), g_amx_scrollmsg_color_blue);
bind_pcvar_num(create_cvar( "amx_scrollmsg_only_dead", "0", _, "Display the message only to dead clients?", true, 0.0, true, 1.0), g_amx_scrollmsg_only_dead);
bind_pcvar_float(create_cvar( "amx_scrollmsg_speed", "0.3", _, "The rate at which the message will move", true, 0.0), g_amx_scrollmsg_speed);
bind_pcvar_float(create_cvar( "amx_scrollmsg_x_move_amount", "0.0063", _, "The amount of units to move on the X axis"), g_amx_scrollmsg_x_move_amount);
bind_pcvar_float(create_cvar( "amx_scrollmsg_x_start_pos", "0.35", _, "Starting position on the X axis", true, -1.0, true, 1.0), g_amx_scrollmsg_x_start_pos);
bind_pcvar_float(create_cvar( "amx_scrollmsg_x_end_pos", "0.65", _, "Ending position on the X axis", true, -1.0, true, 1.0), g_amx_scrollmsg_x_end_pos);
bind_pcvar_float(create_cvar( "amx_scrollmsg_y_pos", "0.9", _, "The Y position of the message", true, -1.0, true, 1.0), g_amx_scrollmsg_y_pos);

g_hud_object = CreateHudSyncObj();
AutoExecConfig();
}

public showMsg()
{
new a = g_startPos, i = 0
new a = g_start_pos, i = 0;

while (a < g_endPos)
g_displayMsg[i++] = g_scrollMsg[a++]
while (a < g_end_pos)
{
g_display_msg[i++] = g_scroll_msg[a++];
}

g_displayMsg[i] = 0
g_display_msg[i] = 0;

if (g_endPos < g_Length)
g_endPos++
if (g_end_pos < g_length)
{
g_end_pos++;
}

if (g_xPos > 0.35)
g_xPos -= 0.0063
if (g_x_pos > g_amx_scrollmsg_x_start_pos)
{
g_x_pos -= g_amx_scrollmsg_x_move_amount;
}
else
{
g_startPos++
g_xPos = 0.35
g_start_pos++;
g_x_pos = g_amx_scrollmsg_x_start_pos;
}

set_hudmessage(200, 100, 0, g_xPos, 0.90, 0, SPEED, SPEED, 0.05, 0.05, 2)
show_hudmessage(0, "%s", g_displayMsg)
set_hudmessage(g_amx_scrollmsg_color_red, g_amx_scrollmsg_color_green, g_amx_scrollmsg_color_blue, g_x_pos, g_amx_scrollmsg_y_pos, 0, g_amx_scrollmsg_speed, g_amx_scrollmsg_speed, 0.05, 0.05, 2);

if (g_amx_scrollmsg_only_dead)
{
new players[MAX_PLAYERS], pnum;
get_players_ex(players, pnum, GetPlayers_ExcludeBots | GetPlayers_ExcludeHLTV | GetPlayers_ExcludeAlive);

for (new i; i < pnum; i++)
{
ShowSyncHudMsg(players[i], g_hud_object, g_display_msg);
}
}
else
{
ShowSyncHudMsg(0, g_hud_object, g_display_msg);
}
}

public msgInit()
{
g_endPos = 1
g_startPos = 0
g_xPos = 0.65
g_end_pos = 1;
g_start_pos = 0;
g_x_pos = g_amx_scrollmsg_x_end_pos;

new hostname[64]
replace_stringex(g_scroll_msg, charsmax(g_scroll_msg), "%hostname%", g_hostname);

get_cvar_string("hostname", hostname, charsmax(hostname))
replace(g_scrollMsg, charsmax(g_scrollMsg), "%hostname%", hostname)
g_length = strlen(g_scroll_msg);

g_Length = strlen(g_scrollMsg)

set_task(SPEED, "showMsg", 123, "", 0, "a", g_Length + 48)
client_print(0, print_console, "%s", g_scrollMsg)
set_task_ex(g_amx_scrollmsg_speed, "showMsg", SCROLLMSG_TASK, "", 0, SetTask_RepeatTimes, g_length + 48);
console_print(0, g_scroll_msg);
}

public setMessage()
{
remove_task(123) /* remove current messaging */
read_argv(1, g_scrollMsg, charsmax(g_scrollMsg))

g_Length = strlen(g_scrollMsg)

new mytime[32]
remove_task(SCROLLMSG_TASK); /* remove current messaging */
read_argv(1, g_scroll_msg, charsmax(g_scroll_msg));

read_argv(2, mytime, charsmax(mytime))
g_length = strlen(g_scroll_msg);
g_frequency = read_argv_int(2);

g_Frequency = str_to_num(mytime)

if (g_Frequency > 0)
if (g_frequency > 0)
{
new minimal = floatround((g_Length + 48) * (SPEED + 0.1))
new minimal = floatround((g_length + 48) * (g_amx_scrollmsg_speed + 0.1));

if (g_Frequency < minimal)
if (g_frequency < minimal)
{
server_print("%L", LANG_SERVER, "MIN_FREQ", minimal)
g_Frequency = minimal
server_print("%L", LANG_SERVER, "MIN_FREQ", minimal);
g_frequency = minimal;
}

server_print("%L", LANG_SERVER, "MSG_FREQ", g_Frequency / 60, g_Frequency % 60)
set_task(float(g_Frequency), "msgInit", 123, "", 0, "b")
server_print("%L", LANG_SERVER, "MSG_FREQ", g_frequency / 60, g_frequency % 60);
set_task_ex(float(g_frequency), "msgInit", SCROLLMSG_TASK, "", 0, SetTask_Repeat);
}
else
server_print("%L", LANG_SERVER, "MSG_DISABLED")
{
server_print("%L", LANG_SERVER, "MSG_DISABLED");
}

return PLUGIN_HANDLED
return PLUGIN_HANDLED;
}