Modernize and improve scrollmsg.sma #579
Conversation
|
Very nice! |
|
@ClaudiuHKS Thanks, I didn't notice them. I changed them. |
|
Great, it's all done. How do I download the new plugins that have changed the content? |
|
Usage of autoconfigexec, how did he change the plugin parameters to fixed? not using Amxx.cfg? |
|
@all85100 You can't download them just yet. This is a pull request, it's not yet added in AMXX. Be patient. |
| register_srvcmd("amx_scrollmsg", "setMessage", _, "<message> <frequency>"); | ||
| bind_pcvar_string(get_cvar_pointer("hostname"), g_hostname, charsmax(g_hostname)); | ||
|
|
||
| bind_pcvar_num(create_cvar( "amx_scrollmsg_color_red", "200", _, "Red color amount", true, 0.0, true, 255.0), g_amx_scrollmsg_color_red); |
There was a problem hiding this comment.
How about to implode it to one cvar amx_scrollmsg_color 200 100 0?
There was a problem hiding this comment.
Not sure really, both seem fine to me. Let's hear more opinions.
|
This modified plugin, I tested, did not show the contents of amx_scrollmsg "". Does it rely only on autoexecconfig generated files? The Amxx.cfg failed, Autoexecconfig generated files did not amx_ It is best not to use AutoExecConfig, which is not very convenient for language translation and use. |
|
@all85100 If a plugin uses AutoConfigExec() the cvars should be modified from the automatically generated .cfg file for that plugin. In this case amxx.cfg will have no effect because it's executed before the generated .cfg. It's not true that it can't be translated - it can. I don't see how amxx.cfg is better, especially when you need to add new cvars manually after each AMXX update. |
The changes include:
amx_scrollmsg_color_red.amx_scrollmsg_color_green.amx_scrollmsg_color_blue.amx_scrollmsg_only_dead(requested in About the scrollmsg and imessage plugins #571).amx_scrollmsg_speed.amx_scrollmsg_x_move_amount.amx_scrollmsg_x_start_pos.amx_scrollmsg_x_end_pos.amx_scrollmsg_y_pos.create_cvarandbind_pcvar_*functions instead of the old ones.show_hudmessagetoShowSyncHudMsgto prevent overlapping messages if the repeat time is shorter.AutoConfigExec- let me know if you want this to stay. I believe it's better this way rather than adding every cvar inamxx.cfg.