Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precache_player_model #533

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add precache_player_model #533

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a84e1f0
Add precache_player_model
OciXCrom Aug 30, 2018
3e56bba
Use precache_generic for T.mdl and improve replacement
OciXCrom Aug 30, 2018
0b9d9e7
Merge branch 'master' into precache-player-model
OciXCrom Aug 30, 2018
d1e9c0c
-4 to -5
OciXCrom Aug 30, 2018
109837d
Change -5 to charsmax
OciXCrom Aug 30, 2018
f48e728
Use copy instead of replace
OciXCrom Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/include/amxmisc.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,7 @@ stock precache_player_model(const name[], &id = 0)
if(file_exists(model))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way how it should be checked, you need to check if model really needs it rehlds/ReHLDS@9080b9b#diff-462e3f794ed90c12c86f5d8d5b725c4aR5405.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WPMGPRoSToTeMa Which I assume can't be done with a stock?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OciXCrom it can be done through the reading of model file.

id = precache_generic(model);

replace_string(model[strlen(model) - 5], charsmax(model), "T.mdl", ".mdl");
static const extension[] = "T.mdl";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why static ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justgo97 It doesn't need to be defined more than once. It acts like a global variable with a local scope.

Copy link

@justgo97 justgo97 Aug 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static is bad here because its lifetime (or "extent") is the entire run of the program while these stock will be only used in one forward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static is fully OK for local array/string constants. There is no other option:

  1. new isn't appropriate here because it does copying on each function call.
  2. Global constant is bad because we use this constant only in this function, so there is no reason for it to be global.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but this string constant is pretty small in size and in its use having it static means it will stay in memory all the time while its only needed at the 1-2 seconds of map start for plugin_precache forward ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justgo97 no, new = data + stack, static = data.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WPMGPRoSToTeMa I mean in overall which is better for memory ?

public plugin_init()
{
    func1()

    func2()
}

public func1()
{
    new const Block1[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC"
    new const Block2[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC"
    new const Block3[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC"
    new const Block4[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC"
    new const Block5[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC"
    new const Block6[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC"
}

public func2()
{
    static const Block1[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER"
    static const Block2[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER"
    static const Block3[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER"
    static const Block4[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER"
    static const Block5[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER"
    static const Block6[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justgo97 if consider only permanent memory, then they are both the same.

Copy link

@justgo97 justgo97 Aug 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WPMGPRoSToTeMa so for non-permanent memory new is better, which is an advantage for new over static ?

Copy link
Contributor

@rsKliPPy rsKliPPy Aug 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter, you shouldn't spend time deciding that while coding.

replace_string(model[charsmax(extension)], charsmax(model), extension, ".mdl");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

charsmax isn't named good for this case, it would be better to have something like const_strlen.

return precache_model(model);
}