Add precache_player_model #533

OciXCrom · 2018-08-30T14:33:47Z

Since the player model path is always hardcoded (models/player/name/name.mdl) and the functions that set player models demand only the model name instead of the full path, it's nice to have a simple stock to do all the work for us. This stock also checks for a T.mdl file which will prevent a crash if the user didn't add support for this kind of models.

WPMGPRoSToTeMa · 2018-08-30T15:45:44Z

Why T.mdl is precached here, but not precached in precache_model?

Arkshine · 2018-08-30T16:30:58Z

It would be also welcomed to upgrade the existing precache_model to read any model to figure out if there are external textures (T.mdl or t.mdl) and groups (01.mdl, 02.mdl, etc.). I believe ReHLDS already does that now. Then you could base this stock on the upgraded precache_model.

WPMGPRoSToTeMa

Model texture auto-precaching is for another PR. Look into my commits for ReHLDS.

WPMGPRoSToTeMa · 2018-08-30T17:31:13Z

plugins/include/amxmisc.inc

+	if(file_exists(model))
+		id = precache_model(model);
+
+	replace_string(model, charsmax(model), "T.mdl", ".mdl");


I don't like this way, it works because GoldSrc allows only one dot in file path. Imagine if model path is models/player/superT.mdl/superT.mdl.mdl.

@WPMGPRoSToTeMa I changed it to check the last characters only

WPMGPRoSToTeMa · 2018-08-30T17:35:34Z

plugins/include/amxmisc.inc

+stock precache_player_model(const name[], &id = 0)
+{
+	new model[128];
+	formatex(model, charsmax(model), "models/player/%s/%sT.mdl", name, name);


Some models have t.mdl instead of T.mdl, this can be a problem on OS with case-sensitive filesystem (like Linux) rehlds/ReHLDS@6715402.

WPMGPRoSToTeMa · 2018-08-30T17:36:56Z

plugins/include/amxmisc.inc

+	new model[128];
+	formatex(model, charsmax(model), "models/player/%s/%sT.mdl", name, name);
+
+	if(file_exists(model))


This is not the way how it should be checked, you need to check if model really needs it rehlds/ReHLDS@9080b9b#diff-462e3f794ed90c12c86f5d8d5b725c4aR5405.

@WPMGPRoSToTeMa Which I assume can't be done with a stock?

@OciXCrom it can be done through the reading of model file.

WPMGPRoSToTeMa · 2018-08-30T17:38:02Z

plugins/include/amxmisc.inc

+	formatex(model, charsmax(model), "models/player/%s/%sT.mdl", name, name);
+
+	if(file_exists(model))
+		id = precache_model(model);


It is better to precache it via precache_generic, because precache_generic doesn't have limit like precache_model (on ReHLDS).

@WPMGPRoSToTeMa I changed it to generic.

OciXCrom · 2018-08-30T19:01:21Z

@Arkshine @WPMGPRoSToTeMa I'll leave it up to you guys to update precache_model because I don't think I'll be able to do it. I'll stick to the stock.

WPMGPRoSToTeMa · 2018-08-30T19:26:00Z

plugins/include/amxmisc.inc


-	replace_string(model, charsmax(model), "T.mdl", ".mdl");
+	replace_string(model[strlen(model) - 4], charsmax(model), "T.mdl", ".mdl");


Still not the best option, magic 4 should be replaced with something like sizeof("T.mdl") - 1. But anyway replace_string doesn't fit good for me.

@WPMGPRoSToTeMa I changed it to charsmax because sizeof would output 6 instead.

What do you suggest using instead replace_string? I couldn't figure out a way to manually insert a character without using functions.

@OciXCrom copy maybe.

@WPMGPRoSToTeMa I changed it to copy.

Arkshine · 2018-08-30T19:26:25Z

Will do it later if you can't.

justgo97 · 2018-08-30T19:39:31Z

plugins/include/amxmisc.inc

+	if(file_exists(model))
+		id = precache_generic(model);
+
+	static const extension[] = "T.mdl";


why static ?

@justgo97 It doesn't need to be defined more than once. It acts like a global variable with a local scope.

static is bad here because its lifetime (or "extent") is the entire run of the program while these stock will be only used in one forward.

static is fully OK for local array/string constants. There is no other option:

new isn't appropriate here because it does copying on each function call.

Global constant is bad because we use this constant only in this function, so there is no reason for it to be global.

yeah but this string constant is pretty small in size and in its use having it static means it will stay in memory all the time while its only needed at the 1-2 seconds of map start for plugin_precache forward ?

@justgo97 no, new = data + stack, static = data.

@WPMGPRoSToTeMa I mean in overall which is better for memory ?

public plugin_init() { func1() func2() } public func1() { new const Block1[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC" new const Block2[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC" new const Block3[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC" new const Block4[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC" new const Block5[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC" new const Block6[] = "I_M_GOING_TO_STAY_IN_MEMORY_JUST_FOR_THIS_FUNC" } public func2() { static const Block1[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER" static const Block2[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER" static const Block3[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER" static const Block4[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER" static const Block5[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER" static const Block6[] = "I_M_GOING_TO_STAY_IN_MEMORY_FOR_EVER" }

@justgo97 if consider only permanent memory, then they are both the same.

@WPMGPRoSToTeMa so for non-permanent memory new is better, which is an advantage for new over static ?

It doesn't matter, you shouldn't spend time deciding that while coding.

OciXCrom · 2018-08-30T19:41:58Z

@Arkshine Sounds good.

WPMGPRoSToTeMa · 2018-08-30T19:47:34Z

I think support for model texture should be done not in precache_model, but at some other side, like PF_precache_model_I hook in order to precache model texture for all models, not only for precached from plugins (e.g. from amxx modules).

Arkshine · 2018-08-30T19:52:20Z

That would be ideal, but not everyone uses ReHLDS and we can't expect any additional features from Valve.

WPMGPRoSToTeMa · 2018-08-30T20:09:02Z

plugins/include/amxmisc.inc

@@ -921,6 +921,7 @@ stock precache_player_model(const name[], &id = 0)
 	if(file_exists(model))
 		id = precache_generic(model);

-	replace_string(model[strlen(model) - 5], charsmax(model), "T.mdl", ".mdl");
+	static const extension[] = "T.mdl";
+	replace_string(model[charsmax(extension)], charsmax(model), extension, ".mdl");


charsmax isn't named good for this case, it would be better to have something like const_strlen.

WPMGPRoSToTeMa · 2018-08-30T20:53:38Z

@Arkshine we can implement it in amxmodx for non-ReHLDS.

Add precache_player_model

a84e1f0

WPMGPRoSToTeMa reviewed Aug 30, 2018

View reviewed changes

OciXCrom added 2 commits August 30, 2018 20:57

Use precache_generic for T.mdl and improve replacement

3e56bba

Merge branch 'master' into precache-player-model

0b9d9e7

-4 to -5

d1e9c0c

WPMGPRoSToTeMa reviewed Aug 30, 2018

View reviewed changes

Change -5 to charsmax

109837d

justgo97 reviewed Aug 30, 2018

View reviewed changes

WPMGPRoSToTeMa reviewed Aug 30, 2018

View reviewed changes

Use copy instead of replace

f48e728

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add precache_player_model #533

Add precache_player_model #533

OciXCrom commented Aug 30, 2018 •

edited

Loading

WPMGPRoSToTeMa commented Aug 30, 2018

Arkshine commented Aug 30, 2018

WPMGPRoSToTeMa left a comment •

edited

Loading

WPMGPRoSToTeMa Aug 30, 2018

OciXCrom Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

OciXCrom Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

OciXCrom Aug 30, 2018

OciXCrom commented Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

OciXCrom Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

OciXCrom Aug 31, 2018

Arkshine commented Aug 30, 2018

justgo97 Aug 30, 2018

OciXCrom Aug 30, 2018

justgo97 Aug 30, 2018 •

edited

Loading

WPMGPRoSToTeMa Aug 30, 2018

justgo97 Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

justgo97 Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

justgo97 Aug 31, 2018 •

edited

Loading

rsKliPPy Aug 31, 2018 •

edited

Loading

OciXCrom commented Aug 30, 2018

WPMGPRoSToTeMa commented Aug 30, 2018

Arkshine commented Aug 30, 2018

WPMGPRoSToTeMa Aug 30, 2018

WPMGPRoSToTeMa commented Aug 30, 2018


		replace_string(model, charsmax(model), "T.mdl", ".mdl");
		replace_string(model[strlen(model) - 4], charsmax(model), "T.mdl", ".mdl");

Add precache_player_model #533

Are you sure you want to change the base?

Add precache_player_model #533

Conversation

OciXCrom commented Aug 30, 2018 • edited Loading

WPMGPRoSToTeMa commented Aug 30, 2018

Arkshine commented Aug 30, 2018

WPMGPRoSToTeMa left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OciXCrom commented Aug 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arkshine commented Aug 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justgo97 Aug 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justgo97 Aug 31, 2018 • edited Loading

Choose a reason for hiding this comment

rsKliPPy Aug 31, 2018 • edited Loading

Choose a reason for hiding this comment

OciXCrom commented Aug 30, 2018

WPMGPRoSToTeMa commented Aug 30, 2018

Arkshine commented Aug 30, 2018

Choose a reason for hiding this comment

WPMGPRoSToTeMa commented Aug 30, 2018

OciXCrom commented Aug 30, 2018 •

edited

Loading

WPMGPRoSToTeMa left a comment •

edited

Loading

justgo97 Aug 30, 2018 •

edited

Loading

justgo97 Aug 31, 2018 •

edited

Loading

rsKliPPy Aug 31, 2018 •

edited

Loading