p2p: enable p2p http txsync #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/p2p-http-txsync
branch
from
b34e728 to
84f06d4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5922 +/- ##
===============================================
- Coverage 56.04% 56.01% -0.03%
===============================================
Files 482 482
Lines 68078 68099 +21
===============================================
- Hits 38153 38146 -7
- Misses 27327 27349 +22
- Partials 2598 2604 +6 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-http-txsync
branch
from
84f06d4 to
22a0b29
Compare
algorandskiy
changed the title
algorandskiy
commented
Jan 29, 2024
| @@ -167,7 +167,7 @@ type wsPeerCore struct { | |||
| readBuffer chan<- IncomingMessage | |||
| rootURL string | |||
| originAddress string // incoming connection remote host | |||
| client http.Client | |||
| client *http.Client | |||
There was a problem hiding this comment.
GetHTTPClient returns address of this variable, and it cannot be nil. But some client code checked it for nil
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GossipNode.GetRoundTripperwithGossipNode.GetHTTPClientas higher level alternative. (only txsync used GetRoundTripper outside of thenetworkpackage.Test Plan
Added a new unit test to txSync to test p2p flow.