-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: HTTP catchup over p2p network #5898
p2p: HTTP catchup over p2p network #5898
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5898 +/- ##
===============================================
+ Coverage 55.91% 56.04% +0.12%
===============================================
Files 481 482 +1
Lines 67938 68078 +140
===============================================
+ Hits 37987 38153 +166
+ Misses 27375 27326 -49
- Partials 2576 2599 +23 ☔ View full report in Codecov by Sentry. |
ac3bdc5
to
42db834
Compare
* modify setupFullNodes to get rid of non-closing pending ledgers * re-enable some skipped to tests
42db834
to
8f49ad0
Compare
bbc379f
to
17a8fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know a lot about libp2p HTTP handling, but this looks good. I've left some spelling corrections and a test suggestion, but those are minor
Thank you Jason, I'll include these fixes into a followup PR I already started. |
Applied in #5922 |
Summary
slices.SortFunc
interface changegorilla/mux
router and registers self as a root (/
) handler.universalFetcher
to distinguish between p2p and regular tcp peers, peer'srootURL
checked if it is a multiaddrBackoffDiscovery::FindPeers
has a cache so we are not making crazy number or requests to DHT.Test Plan
Added a unit test to
./node
to test http catchup via p2p transport.Reenabled some skipped tests in node_test.go