SHOULD* use etags for DELETE to agents/activity APIs #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ##### Client Requirements | ||
|
|
||
| * A Client using either Agent Profile API or Activity Profile API MUST include the | ||
| * A Client making a PUT request to either the Agent Profile API or Activity Profile API MUST include the |
There was a problem hiding this comment.
IMHO the text above this implied it only related to PUT, so I don't think we can argument POST/DELETE are MUSTs.
| [If-Match](http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.24) header or the | ||
| [If-None-Match](http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.26) header. | ||
|
|
||
| * A Client making a DELETE request to either the Agent Profile API or Activity Profile API SHOULD* include the |
There was a problem hiding this comment.
DELETE doesn't need If-None-Match because you're not going to DELETE something that doesn't exist.
|
+1 I don't see anything here we haven't discussed |
andyjohnson
added a commit
that referenced
this pull request
Dec 30, 2014
SHOULD* use etags for DELETE to agents/activity APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357 remaining issues.
See line comments.