-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
409 Conflict under 7.1 Error Codes specifically calls out PUT for statements but not POST #362
Comments
Fine with this change in patch as sections below clearly reference POST using error code 409. |
Do we also need to look at section 6.3 Concurrency? This currently refers only to PUT (and GET) but not POST. |
I'd think we'd only need POST in the context of if it had a GET in it, but I think we don't need to spell that out here. That's my 2 cents but it is definitely worth discussing! |
I'm not sure I follow your comment, @andyjohnson ; 409 conflict occurs when something is being updated, so this is for true POSTs that update state & profile. I'm fine with this, except the correct response is 412 (per the RFC), not 409, which was an error in the spec. See #356 |
Or rather, both, since it looks like the 409/412 stuff is sorted (and both are potentially appropriate and only fully called out for PUT). |
It seemed to make sense to bundle this in with other edits in the same area. Do we also need to look at section 6.3?
So as a part of 1.0.3, lets rework section 6.3 to take into account these considerations as @garemoko said, sorry for the confusing comment earlier. |
POST of statements should also be mentioned here (when posting a batch of statements there can still be a conflict, in which case 409 should still be used)
The text was updated successfully, but these errors were encountered: