Fix checkout support in CI for Ubuntu 18.04 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
bug
krasznaa
approved these changes
Jul 16, 2024
krasznaa
requested changes
Jul 16, 2024
stephenswat
force-pushed
the
ci/node_patch
branch
from
c696616 to
b5754bb
Compare
The combination of us using the past-EoL Ubuntu 18.04 and Microsoft being a bit gung-ho in their changes to GitHub Actions means that Node16, and by extension checkouts@v3 is no longer supported. Since Ubuntu 18.04 doesn't support the newer Node20, we are stuck. Thankfully, we can set the `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION` environment variable which is project to keep the CI running until they remove support for Node16 fully.
stephenswat
force-pushed
the
ci/node_patch
branch
from
b5754bb to
097a257
Compare
|
There we go, now it's happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of us using the past-EoL Ubuntu 18.04 and Microsoft being a bit gung-ho in their changes to GitHub Actions means that Node16, and by extension checkouts@v3 is no longer supported. Since Ubuntu 18.04 doesn't support the newer Node20, we are stuck. Thankfully, we can set the
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSIONenvironment variable which is project to keep the CI running until they remove support for Node16 fully.See #286 for the related CI failure, and https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ for the GitHub blog post about this.