Revert "Windows CI Fix, main branch (2024.06.11.)" #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently not. 😟 |
|
I guess we can keep it open to have an easy way of testing this going forward. 🤔 |
krasznaa
force-pushed
the
revert-279-WindowsCIFix-main-20240611
branch
from
7db522d to
611312e
Compare
stephenswat
requested changes
Jun 14, 2024
stephenswat
force-pushed
the
revert-279-WindowsCIFix-main-20240611
branch
from
611312e to
65b7db2
Compare
stephenswat
approved these changes
Jun 14, 2024
krasznaa
force-pushed
the
revert-279-WindowsCIFix-main-20240611
branch
from
65b7db2 to
87e80b8
Compare
|
Are these latest failures fixed by #287? I thought that was for a slightly different issue. 🤔 I don't remember such missing glibc symbols as errors so far. |
Co-authored-by: Stephen Nicholas Swatman <[email protected]>
krasznaa
force-pushed
the
revert-279-WindowsCIFix-main-20240611
branch
from
87e80b8 to
7baab7b
Compare
|
Looks good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #279.
The claim in actions/runner-images#10004 is that the GitHub Windows runners are now back to not needing this workaround anymore. So, let's see...