Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMQ-2686 - Fix channel journals #2685

Merged
merged 2 commits into from
Feb 6, 2025

fix: add connect and disconnect event journals

86283ae
Select commit
Loading
Failed to load commit list.
Merged

SMQ-2686 - Fix channel journals #2685

fix: add connect and disconnect event journals
86283ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 6, 2025 in 1s

35.96% (-7.91%) compared to 3cb41fa

View this Pull Request on Codecov

35.96% (-7.91%) compared to 3cb41fa

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (3cb41fa) to head (86283ae).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
journal/middleware/authorization.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   43.87%   35.96%   -7.91%     
==========================================
  Files         350       40     -310     
  Lines       45718     6631   -39087     
==========================================
- Hits        20059     2385   -17674     
+ Misses      23438     4052   -19386     
+ Partials     2221      194    -2027     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.