Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix channel journals #2685

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a bug fix because it fixes not being able to retrieve channel journals.

What does this do?

This pr adds channel entity type to be able to authorize and view channel journals.

Which issue(s) does this PR fix/relate to?

Noissue

Have you included tests for your changes?

No, tested manually.

Did you document any new/modified feature?

No

Notes

None

Signed-off-by: Felix Gateru <[email protected]>
@felixgateru felixgateru changed the title NOISSUE - FIx channel journals NOISSUE - Fix channel journals Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (3cb41fa) to head (151a69c).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
journal/middleware/authorization.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
- Coverage   43.87%   35.96%   -7.91%     
==========================================
  Files         350       40     -310     
  Lines       45718     6631   -39087     
==========================================
- Hits        20059     2385   -17674     
+ Misses      23438     4052   -19386     
+ Partials     2221      194    -2027     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant