Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sites: Add a "Day of Event" page to new sites #241

Merged
merged 5 commits into from
Jan 7, 2020

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Sep 25, 2019

This creates a new page that will use the Day of Event template on new sites. It includes the Live Schedule block from #243, and the live Latest Posts block from #250. Now that all this content is blocks, organizers can fully control the information & style of this page.

To test

  • Create a new WordCamp site
  • The new site should pre-populate with a page called "Day of Event", with useful information for during the camp (date, location, live schedule, latest posts).

@ryelle ryelle self-assigned this Sep 30, 2019
@ryelle ryelle added [Component] Theme Templates Theme-agnostic templates like Day of Event, Offline [Status] On Hold labels Sep 30, 2019
@ryelle
Copy link
Contributor Author

ryelle commented Oct 7, 2019

This will wait on #243 & #250 – once those are merged, we can use the new blocks to replicate the existing Day of Event template, and remove the duplicate JS code.

@ryelle ryelle added this to the PWA beta version milestone Oct 8, 2019
@ryelle
Copy link
Contributor Author

ryelle commented Oct 11, 2019

Live "Latest Posts" block requires the Gutenberg plugin to be active.

@ryelle ryelle force-pushed the update/stubs-create-day-of-page branch from 41ec168 to 17dfeeb Compare October 14, 2019 20:31
@ryelle ryelle marked this pull request as ready for review October 14, 2019 21:35
@ryelle ryelle force-pushed the update/stubs-create-day-of-page branch 2 times, most recently from 2f16bc7 to 6a74dfa Compare October 15, 2019 18:02
@ryelle ryelle force-pushed the update/stubs-create-day-of-page branch from 6a74dfa to d214da7 Compare January 6, 2020 21:03
@ryelle
Copy link
Contributor Author

ryelle commented Jan 7, 2020

Now that these blocks are enabled for everyone, this is actually ready for review :)

Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested locally

array(
'title' => __( 'Day Of Event', 'wordcamporg' ),
'content' => $this->get_stub_content( 'page', 'day-of-event', $wordcamp ),
'status' => 'publish',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be draft instead of publish, since the page is only intended to be used near the time of the actual event?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's a good idea 👍

@ryelle ryelle merged commit 60b500c into production Jan 7, 2020
@ryelle ryelle deleted the update/stubs-create-day-of-page branch January 7, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates Theme-agnostic templates like Day of Event, Offline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants