Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Live Schedule and Live Post blocks #305

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Enable Live Schedule and Live Post blocks #305

merged 1 commit into from
Jan 7, 2020

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Jan 6, 2020

This removes the site filter on Live Schedule & the live Latest Posts block, so these features are available to all sites.

This is part of opening the PWA features to all sites, and is needed before merging #241.

How to test the changes in this Pull Request:

  1. Set WORDCAMP_ENVIRONMENT to "production"
  2. Check that the Live Schedule block is still available
  3. Check that Latest Posts has a "live updates" toggle setting

@ryelle
Enable Live Schedule and Live Post blocks
c4c19b6 
This removes the site filter on Live Schedule & the live Latest Posts block, so these features are available to all sites.
@ryelle ryelle added [Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Component] PWA Service workers, manifest labels Jan 6, 2020
@ryelle ryelle requested review from iandunn and coreymckrill January 6, 2020 21:40
@ryelle ryelle self-assigned this Jan 6, 2020
@ryelle ryelle added this to the PWA beta version milestone Jan 6, 2020
coreymckrill
coreymckrill approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested

@ryelle ryelle merged commit 4210e51 into production Jan 7, 2020
@ryelle ryelle deleted the enable/live-blocks branch January 8, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreymckrill coreymckrill coreymckrill approved these changes

@iandunn iandunn Awaiting requested review from iandunn

Assignees

@ryelle ryelle

Labels
[Component] Blocks All custom blocks (Speakers, CrowdCast, Live Schedule, etc) [Component] PWA Service workers, manifest
Projects
None yet
Milestone
PWA beta version
Development

Successfully merging this pull request may close these issues.
2 participants
@ryelle @coreymckrill