Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FocalPointPicker unit test to tsx #60935

Closed
wants to merge 2 commits into from
Closed

Refactor FocalPointPicker unit test to tsx #60935

wants to merge 2 commits into from

Conversation

alpha951
Copy link

What?

  • Renamed the unit tests files for FocalPointPicker component to .tsx files.
  • Added jest types dev dependency.

Why?

  • To make unit tests typechecked.

How?

  • Renamed the unit test files to .tsx

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@alpha951 alpha951 requested a review from ajitbohra as a code owner April 21, 2024 16:08
Copy link

github-actions bot commented Apr 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: alpha951 <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 21, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @alpha951! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@alpha951
Copy link
Author

Fixes : #60529

@alpha951
Copy link
Author

Please review the changes @WordPress/gutenberg-components

@mirka
Copy link
Member

mirka commented Apr 22, 2024

👋 Hi, thanks for the PR!

The baseline success check for this task is for npm run build:package-types to pass without errors. There are some changes that need to be made in the test file for type checks to pass.

Also, we don't need to add a @types/jest dependency because they are already available (see npm ls @types/jest).

@mirka mirka requested a review from a team April 22, 2024 20:12
@skorasaurus skorasaurus added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Apr 24, 2024
@mirka
Copy link
Member

mirka commented May 16, 2024

This was fixed by another contributor in #61373. Thank you for the attempt 🙏

@mirka mirka closed this May 16, 2024
@alpha951 alpha951 deleted the refactor-FocalPointPicker-unittest-to-tsx branch July 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants