Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FocalPointPicker: Convert unit tests to TypeScript #60529

Closed
mirka opened this issue Apr 6, 2024 · 6 comments
Closed

FocalPointPicker: Convert unit tests to TypeScript #60529

mirka opened this issue Apr 6, 2024 · 6 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@mirka
Copy link
Member

mirka commented Apr 6, 2024

Convert the unit test files to .tsx so they are typechecked, and resolve any errors.
@mirka mirka added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Components /packages/components labels Apr 6, 2024
@alpha951
Copy link

Hey, could you please assign this issue to me.

@mirka
Copy link
Member Author

mirka commented Apr 16, 2024 •
edited
Loading

@alpha951 Hi there 👋 Feel free to submit a PR, and it should assign you automatically once you link back to this issue, e.g. by writing Fixes #60529 in the PR description. Ping @WordPress/gutenberg-components for review when it's ready!

@alpha951 alpha951 mentioned this issue Apr 21, 2024
Closed
@alpha951
Copy link

Hey @mirka , I've raised PR #60935. But seems like I couldn't tag @WordPress/gutenberg-components for review. Also the github checks are also failing.

@jpstevens jpstevens mentioned this issue May 3, 2024
Merged
@jpstevens
Copy link
Contributor

Hey @mirka 👋 Can I get a review of this PR please? #61373

All checks are passing except for the "enforce labels" check - as I don't have permission to assign one.

Thanks!

@mirka
Copy link
Member Author

mirka commented May 7, 2024

@jpstevens Thank you for the contribution! I've put this in our review queue 👍

@Mamaduka
Copy link
Member

Resolved by #61373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Mamaduka @mirka @jpstevens @alpha951