Removing Blender Lighting and Camera information from visual DAE files #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for bringing that up. We were aware of this but it never seemed severe enough to fix it. If it destroys view on MoveIt Pro that's definitively to be fixed. Grepping through the meshes, that seems also to be present in ur3, ur5 and ur10. Can you confirm that they show the same issues? |
|
@mewtwoshaurd I've updated the CB3 robots without cameras in urfeex@8a31009 Could you verify that this also helps with MoveIt Pro, please? Feel free to cherry-pick that commit into this PR, so we can merged all at once. |
This was referenced Jan 21, 2025
Merged
|
cherry picked and tested, this does fix all the lighting issues. thanks so much! |
|
Glad to hear that, thanks for testing! |
urfeex
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
ur20description has Blender lighting and cameras that will render in the MoveIt Pro app and makes the visual mesh look incorrect:This PR removes those Blender artifacts.
It would be great if we could backport this to humble as well!