-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-165] - Prevent double Base64 encoding of profile href + Github Actions updates #166
Conversation
Download and run the latest build with:
|
Thanks @soufianerafik I'll run it locally to double check. |
Please add a quick summary of the other changes you made here. You don't need to create new issues, but we may need to look back at some point and see when these were fixed. Also, I remember the endpoint to PWS changed. Can you add that here? I need it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me..
with: | ||
github-token: ${{ env.GITHUB_TOKEN }} | ||
github-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soufianerafik and I clarified where the notes are and where to find another change I was looking for.
Change Description: This PR fixes a bug in the
b64_encode_href
method of the Person model that caused double Base64 encoding of thehref
when navigating back in the browser. Changes I've made:b64_encode_href
validator:href
is already Base64 encoded before encoding it again, preventing the double encoding issue.Closes Github(s): GH-165
UW-Directory Pull Request checklist
poetry run tox
semver-guidance:
label for this pull request (under labels,to the right of the screen)