Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-165] - Prevent double Base64 encoding of profile href + Github Actions updates #166

Merged
merged 11 commits into from
Jan 16, 2025

Conversation

soufianerafik
Copy link
Contributor

@soufianerafik soufianerafik commented Jan 16, 2025

Change Description: This PR fixes a bug in the b64_encode_href method of the Person model that caused double Base64 encoding of the href when navigating back in the browser. Changes I've made:

  1. Updated b64_encode_href validator:
    • The method now checks if the href is already Base64 encoded before encoding it again, preventing the double encoding issue.
Screenshot 2025-01-15 at 10 04 14 PM
  1. Github Actions:
    • Automated tests were failing due to outdated dependencies.
    • Switched to using pipx for installing Poetry and updated the Google dependencies.
Screenshot 2025-01-15 at 10 52 37 PM

Closes Github(s): GH-165

UW-Directory Pull Request checklist

  • I have run poetry run tox
  • I have selected a semver-guidance: label for this pull request (under labels,
    to the right of the screen)

Copy link
Contributor

Download and run the latest build with:

./scripts/run-development-server.sh -i gcr.io/uwit-mci-iam/husky-directory.app:pull-request-166

@soufianerafik soufianerafik marked this pull request as ready for review January 16, 2025 06:57
@soufianerafik soufianerafik changed the title fix(backend): Prevent double Base64 encoding of profile href [GH-165] - Prevent double Base64 encoding of profile href + Github Actions updates Jan 16, 2025
@goulter
Copy link
Contributor

goulter commented Jan 16, 2025

Thanks @soufianerafik I'll run it locally to double check.

@goulter
Copy link
Contributor

goulter commented Jan 16, 2025

Please add a quick summary of the other changes you made here. You don't need to create new issues, but we may need to look back at some point and see when these were fixed.

Also, I remember the endpoint to PWS changed. Can you add that here? I need it :)

Copy link
Contributor

@jdiverp jdiverp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me..

with:
github-token: ${{ env.GITHUB_TOKEN }}
github-token: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, thanks!

Copy link
Contributor

@goulter goulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soufianerafik and I clarified where the notes are and where to find another change I was looking for.

@soufianerafik soufianerafik merged commit 408312d into main Jan 16, 2025
2 checks passed
@soufianerafik soufianerafik deleted the GH-165 branch January 16, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants