feat: Add checks for overwrite protection before running expensive operations #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-running-expensive-operations
…re-running-expensive-operations
…re-running-expensive-operations
…re-running-expensive-operations
@SoloSynth1 not sure if we can avoid these warnings, other than that, looks good to me
|
JohnShiuMK
approved these changes
Jun 20, 2024
JohnShiuMK
deleted the
163-add-checks-for-overwrite-protection-before-running-expensive-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a file overwrite check in expensive operation i.e.
evaluatebefore the expensive calls (e.g. calls to APIs) happens.Now, if the command runs when supplied with a
-e/--export-report-toargument AND without a-o/--overwriteargument, it will check if a file has existed in the path. If yes, it will raise error and exit WITHOUT running the API calls.This PR also adds a relevant test on the check, and re-organized all test fixtures into a root-level
conftest.py.Closes #163.