Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added line numbers and hyperlink by function and file #107

Merged
merged 27 commits into from
Jun 6, 2024
Merged

feat: added line numbers and hyperlink by function and file #107

merged 27 commits into from
Jun 6, 2024
+551 −145

Conversation

JohnShiuMK
Copy link
Collaborator

@JohnShiuMK JohnShiuMK commented May 27, 2024 •
edited by SoloSynth1
Loading

close #104, closes #109, and closes #123.

@JohnShiuMK JohnShiuMK self-assigned this May 27, 2024
@JohnShiuMK JohnShiuMK requested a review from SoloSynth1 May 27, 2024 21:00
@JohnShiuMK JohnShiuMK marked this pull request as ready for review May 27, 2024 21:59
@JohnShiuMK
Copy link
Collaborator Author

Hi @SoloSynth1, it's ready for review.

I needed to work with the report output so I merged the 82-export-report-refactor' into 104-add-line-number.

In case you find the "Files changed" confusing, here are the files I have edited and am looking for reviews:

  • src/test_creation/modules/code_analyzer/analyzers/python.py
  • src/test_creation/modules/code_analyzer/repo.py
  • src/test_creation/modules/workflow/parse.py
  • src/test_creation/analyze.py

@JohnShiuMK JohnShiuMK changed the title feat: added line numbers by function and file feat: added line numbers and hyperlink by function and file May 28, 2024
@JohnShiuMK JohnShiuMK linked an issue May 28, 2024 that may be closed by this pull request
(Optional) Embed hyperlink to the line number #109
Closed
@JohnShiuMK JohnShiuMK mentioned this pull request May 28, 2024
Merged
SoloSynth1
SoloSynth1 reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@SoloSynth1 SoloSynth1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the belated review! Please see the comments.

@SoloSynth1
Copy link
Collaborator

This closes #123 as well.

SoloSynth1
SoloSynth1 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@SoloSynth1 SoloSynth1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm holding off the merge to see if anyone is interested in doing a manual check.

@SoloSynth1 SoloSynth1 mentioned this pull request Jun 5, 2024
Merged
@JohnShiuMK JohnShiuMK linked an issue Jun 6, 2024 that may be closed by this pull request
Add check to make sure the fields output by LLM are completed #137
Closed
JohnShiuMK
JohnShiuMK commented Jun 6, 2024
View reviewed changes
Copy link
Collaborator Author

@JohnShiuMK JohnShiuMK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, look good to me too

@JohnShiuMK JohnShiuMK merged commit 080cdba into main Jun 6, 2024
2 checks passed
@JohnShiuMK JohnShiuMK deleted the 104-add-line-number branch June 6, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoloSynth1 SoloSynth1

Assignees

@JohnShiuMK JohnShiuMK

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JohnShiuMK @SoloSynth1