Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add check to validate returned LLM response to have the same no. of items as input #101

Merged
merged 3 commits into from
May 30, 2024
Merged

feat: Add check to validate returned LLM response to have the same no. of items as input #101

merged 3 commits into from
May 30, 2024

Conversation

SoloSynth1
Copy link
Collaborator

As title.

Closes #100.

@SoloSynth1 SoloSynth1 self-assigned this May 27, 2024
@SoloSynth1 SoloSynth1 linked an issue May 27, 2024 that may be closed by this pull request
Add validate check to evaluate the completeness of the checklist items from the response #100
Closed
@JohnShiuMK
Copy link
Collaborator

@SoloSynth1

Finding in #107 :
Screenshot 2024-05-28 at 3 01 08 PM

The LLM response sometimes misses the "Functions", especially Evaluation is "Not Satisfied", which trigger an error in the line number extraction code.
I think we need to add a check to ensure the fields in the output are completed. (and/or we can modify to line number extraction code in #107 to better handle the case)

@JohnShiuMK JohnShiuMK mentioned this pull request May 30, 2024
Closed
JohnShiuMK
JohnShiuMK approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@JohnShiuMK JohnShiuMK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. let's merge for now and open another PR if we encounter any problems

@JohnShiuMK JohnShiuMK merged commit 1e38da6 into main May 30, 2024
@JohnShiuMK JohnShiuMK deleted the 100-add-validate-check-to-evaluate-the-completeness-of-the-checklist-items-from-the-response branch May 30, 2024 01:12
@JohnShiuMK JohnShiuMK linked an issue May 30, 2024 that may be closed by this pull request
Consistancy Issue #119
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnShiuMK JohnShiuMK JohnShiuMK approved these changes

@tonyshumlh tonyshumlh Awaiting requested review from tonyshumlh

@jinyz8888 jinyz8888 Awaiting requested review from jinyz8888

Assignees

@SoloSynth1 SoloSynth1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistancy Issue Add validate check to evaluate the completeness of the checklist items from the response
2 participants
@SoloSynth1 @JohnShiuMK