Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect PATH env variable for runitdir in alpine #152 #153

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

q0rban
Copy link
Contributor

@q0rban q0rban commented Dec 10, 2024

An alternate solution to #152

Resolves #152

Testing instructions:

  • task -- alpine
  • Then run each tag created to see if they are healthy:
$ image=tugboatqa/alpine:3.20.3

$ container=$(docker run --detach --rm $image)

$ docker ps --filter "id=$container" --format "{{ .State }}"
running

$ docker rm -f $container

Copy link
Contributor

@rabbitlair rabbitlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, and all tags worked like a charm during my tests. Thank you!

@rabbitlair rabbitlair merged commit b1915a9 into main Dec 11, 2024
4 checks passed
@rabbitlair rabbitlair deleted the 152--use-path-alpine-runit branch December 11, 2024 11:51
Copy link

@jcbain jcbain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the review but I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpine 3.21 uses a different installation directory for runit
3 participants