#152 fix: alter RUNITDIR for alpine 3.21 #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbain
reviewed
Dec 10, 2024
| # Alpine 3.21.* installs runit into a different directory. Test if this is 3.21 | ||
| # and then modify the above script appropriately. | ||
| RUN source /etc/os-release && \ | ||
| test "${VERSION_ID#3.21.}" = "$VERSION_ID" || \ |
There was a problem hiding this comment.
I know we have no way of knowing what future tags will do but would the idea to be to keep adding to this check to any tags that also modify the location?
There was a problem hiding this comment.
Good question… alternately, we could assume future versions will keep this change, and only do this modification for lower versions.
There was a problem hiding this comment.
My intuition would be for this change to be maintained in future versions but perhaps we should let it fail again to ensure that is the case and if it is we can change it then.
jcbain
approved these changes
Dec 10, 2024
q0rban
changed the title
q0rban
force-pushed
the
noticket--alpine-3.21-runitdir
branch
from
efcf944 to
4272766
Compare
|
I prefer the solution in #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #152
Testing instructions
task -- alpinedocker run --detach --rm tugboatqa/alpine:3.21.0docker stop