Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steps): remove custom and custom sql deprecated steps from action menu [TCTC-7178] #2059

Merged
merged 2 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- ActionMenu: remove deprecated Custom and Custom Sql step from action menu

## [0.111.3] - 2024-03-11

### Fixed
Expand Down
2 changes: 0 additions & 2 deletions ui/src/components/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ export const ACTION_CATEGORIES: ActionCategories = {
{ name: 'text', label: 'Add text column' },
{ name: 'formula', label: 'Add formula column' },
{ name: 'ifthenelse', label: 'Add conditional column' },
{ name: 'custom', label: 'Add custom step' },
{ name: 'customsql', label: 'Add custom sql step' },
Comment on lines -39 to -40
Copy link
Member

@davinov davinov Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that also hide them from search?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ils n'étaient déjà pas visibles

],
filter: [
{ name: 'delete', label: 'Delete columns' },
Expand Down
4 changes: 1 addition & 3 deletions ui/tests/unit/action-toolbar-button.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ describe('ActionToolbarButton active', () => {
'Add text column',
'Add formula column',
'Add conditional column',
'Add custom step',
'Add custom sql step',
]);
});

Expand Down Expand Up @@ -176,7 +174,7 @@ describe('ActionToolbarButton active', () => {

const actionsWrappers = wrapper.findAll('.action-menu__option');
const actionsIsDisabled = actionsWrappers.wrappers.map((w) => w.props().isDisabled);
expect(actionsIsDisabled).toEqual([false, false, false, true, true]);
expect(actionsIsDisabled).toEqual([false, false, false]);
});

it('should instantiate a Date button with the right list of actions', () => {
Expand Down
Loading