fix(steps): remove custom and custom sql deprecated steps from action menu [TCTC-7178] #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinov
reviewed
Apr 4, 2024
Comment on lines
-39
to
-40
| { name: 'custom', label: 'Add custom step' }, | ||
| { name: 'customsql', label: 'Add custom sql step' }, |
There was a problem hiding this comment.
Does that also hide them from search?
There was a problem hiding this comment.
Ils n'étaient déjà pas visibles
davinov
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the deprecated 'Custom sql' and 'Custom' steps from action menu.
It won't be usable anymore with hybrid pipeline
ℹ️ We don't remove steps code and pipeline listing because we may have migrated apps with custom steps so we want them to be removed before cleaning the code
The customs steps are still accessible (to be deleted) if a step has been created earlier but app builder won't be able to create new ones