Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-shell): refresh app shell UX #2102

Merged
merged 16 commits into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions apps/docs-app/src/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ $mat-font-url: './';
@include covalent-colors();

$background: map-get($td-light-theme, background);

// Include theme styles for core and each component used in your app.
// Alternatively, you can import and @include the theme mixins for each component
// that you are using.
@include mat.core-theme($td-light-theme);
@include mat.all-component-themes($td-light-theme);
@include covalent-theme($td-light-theme);
@include covalent-markdown-theme($td-light-theme);
Expand Down Expand Up @@ -75,8 +72,8 @@ body .mat-card {
// Dark theme
.theme-dark {
$background: map-get($td-dark-theme, background);

@include mat.all-component-themes($td-dark-theme);
@include mat.core-theme($td-dark-theme);
@include mat.all-component-colors($td-dark-theme);
@include covalent-theme($td-dark-theme);
@include covalent-markdown-theme($td-dark-theme);
@include covalent-highlight-theme($td-dark-theme);
Expand Down
24 changes: 20 additions & 4 deletions apps/knapsack/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,14 @@
"npx knapsack --config apps/knapsack/knapsack.config.js build"
],
"parallel": false
}
},
"dependsOn": [
{
"projects": ["components"],
"target": "build",
"params": "ignore"
}
]
},
"start": {
"executor": "nx:run-commands",
Expand All @@ -22,7 +29,8 @@
"npx knapsack --config apps/knapsack/knapsack.config.js start"
],
"parallel": false
}
},
"dependsOn": ["build"]
},
"serve": {
"executor": "nx:run-commands",
Expand All @@ -32,7 +40,8 @@
"NODE_ENV=production npx knapsack --config apps/knapsack/knapsack.config.js serve"
],
"parallel": false
}
},
"dependsOn": ["build"]
},
"test": {
"executor": "nx:run-commands",
Expand All @@ -42,7 +51,14 @@
"npx knapsack --config apps/knapsack/knapsack.config.js test"
],
"parallel": false
}
},
"dependsOn": [
{
"projects": ["components"],
"target": "build",
"params": "ignore"
}
]
}
},
"tags": []
Expand Down
54 changes: 53 additions & 1 deletion docs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# [8.4.0-beta.1](https://github.com/Teradata/covalent/compare/v8.3.1...v8.4.0-beta.1) (2024-02-26)

### Bug Fixes

- **app-shell:** mobile styles with help open ([224c8f6](https://github.com/Teradata/covalent/commit/224c8f67589c22cf6676b3ef4798e0dc9a3a3064))
- **compoents:** updating tokens import path ([be89cc7](https://github.com/Teradata/covalent/commit/be89cc73bd331365df9698667b02c6bfc8afe452))
- **components:** adding packages for secondary ([488e970](https://github.com/Teradata/covalent/commit/488e9707e9db8a8c4381e68271e5697140504843))

### Features

- **appshell:** sticky scrolling for headers ([0f679ec](https://github.com/Teradata/covalent/commit/0f679ec2be4ec6059a09b194dc8e32c6ee3e939c))
- **appshell:** updating scrolling behavior ([66e2b30](https://github.com/Teradata/covalent/commit/66e2b30b8849944eb0e9b6b59ad51a002e3873f7))
- **components:** updating text in story for app shell ([5d6c30a](https://github.com/Teradata/covalent/commit/5d6c30a2ba8e42a0ed304c2441cd3c2e5988e9f1))

## [8.3.1](https://github.com/Teradata/covalent/compare/v8.3.0...v8.3.1) (2024-02-22)

### Bug Fixes
Expand All @@ -12,9 +26,47 @@

## [8.2.1](https://github.com/Teradata/covalent/compare/v8.2.0...v8.2.1) (2024-02-16)

# [8.4.0-beta.3](https://github.com/Teradata/covalent/compare/v8.4.0-beta.2...v8.4.0-beta.3) (2024-02-22)

### Features

- **appshell:** sticky scrolling for headers ([a0fcd86](https://github.com/Teradata/covalent/commit/a0fcd86d4ba3a9d95d8b8cef2d625737d8b830e1))

# [8.4.0-beta.2](https://github.com/Teradata/covalent/compare/v8.4.0-beta.1...v8.4.0-beta.2) (2024-02-22)

### Bug Fixes

- **app-shell:** mobile styles with help open ([0042c17](https://github.com/Teradata/covalent/commit/0042c173e6f73036d729d3716bfc6e167ee0a823))

# [8.4.0-beta.1](https://github.com/Teradata/covalent/compare/v8.3.0...v8.4.0-beta.1) (2024-02-21)

### Bug Fixes

- **tokens:** updating logo on background ([#2098](https://github.com/Teradata/covalent/issues/2098)) ([e560cc9](https://github.com/Teradata/covalent/commit/e560cc9efe8ee5744e38a1274823292341b5bac5))
- **compoents:** updating tokens import path ([028a855](https://github.com/Teradata/covalent/commit/028a8557435a6d2123f0fe226c93204e80d0f99c))
- **components:** adding packages for secondary ([920921b](https://github.com/Teradata/covalent/commit/920921bcb408aa197da144e2e025f3bbcd8ea5e9))

### Features

- **appshell:** updating scrolling behavior ([ab68edc](https://github.com/Teradata/covalent/commit/ab68edc4f1d6a15805b8c26477957e6b480a1fb8))
- **components:** updating text in story for app shell ([d8d8bb5](https://github.com/Teradata/covalent/commit/d8d8bb5a075c79d2f116349aa34b87887dad131e))

# [8.3.0-beta.3](https://github.com/Teradata/covalent/compare/v8.3.0-beta.2...v8.3.0-beta.3) (2024-02-20)

### Bug Fixes

- **compoents:** updating tokens import path ([b5294c8](https://github.com/Teradata/covalent/commit/b5294c834fcbf57c4a72242b198d0fcf7c900005))

# [8.3.0-beta.2](https://github.com/Teradata/covalent/compare/v8.3.0-beta.1...v8.3.0-beta.2) (2024-02-20)

### Bug Fixes

- **components:** adding packages for secondary ([3e0c211](https://github.com/Teradata/covalent/commit/3e0c211c442cbbdbd80f45b1392cc27e144af13e))

# [8.3.0-beta.1](https://github.com/Teradata/covalent/compare/v8.2.0...v8.3.0-beta.1) (2024-02-16)

### Features

- **components:** updating text in story for app shell ([dabd2c7](https://github.com/Teradata/covalent/commit/dabd2c7bb76b73fde6bf9afa659b41ffc23c62e8))

# [8.2.0](https://github.com/Teradata/covalent/compare/v8.1.0...v8.2.0) (2024-02-14)

Expand Down
9 changes: 9 additions & 0 deletions libs/components/.storybook/manager-head.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@
color: var(--cv-dark-on-primary);
}

.light #storybook-explorer-tree .sidebar-item[data-selected='true'],
.light #storybook-explorer-tree .sidebar-item[data-selected='true'] svg {
color: var(--cv-light-on-primary);
}
.dark #storybook-explorer-tree .sidebar-item[data-selected='true'],
.dark #storybook-explorer-tree .sidebar-item[data-selected='true'] svg {
color: var(--cv-dark-on-primary);
}

.light #storybook-explorer-tree .sidebar-item[data-selected='false'] svg {
color: var(--cv-light-secondary);
}
Expand Down
140 changes: 58 additions & 82 deletions libs/components/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
/>
</head>
<body>
<cv-app-shell appName="[App Name]" sectionName="Environments">
<cv-app-shell appName="[App Name]" sectionName="Environments" contained>
<svg
slot="logo"
width="103"
Expand All @@ -37,39 +37,30 @@
>
<path
d="M0 2.30182H3.53561V5.6615H7.47898V8.88045H3.53561V14.5072C3.53561 15.9632 4.26909 16.4391 5.30341 16.4391H7.47898V19.658H5.30341C1.68575 19.658 0 18.0358 0 14.5072V2.30182Z"
fill="#FF5F02"
/>
<path
d="M15.9376 19.9907C11.5865 19.9907 8.67492 17.0506 8.67492 12.6854C8.67492 8.32008 11.5318 5.32374 15.7461 5.32374C19.9605 5.32374 22.708 8.17934 22.708 12.5446C22.708 12.9643 22.6806 13.4121 22.5986 13.9443H12.3746C12.7003 15.9043 13.8714 16.828 15.9923 16.828C17.325 16.828 18.3046 16.2395 18.685 15.4565H22.33C21.5145 18.1714 19.2295 19.9907 15.9376 19.9907ZM12.4293 10.9787H19.0107C18.6577 9.21565 17.6233 8.37637 15.7461 8.37637C13.9783 8.37637 12.8371 9.27194 12.4293 10.9787Z"
fill="#FF5F02"
/>
<path
d="M24.6672 5.65895H28.0661V7.33751C29.3167 6.05044 30.8135 5.40563 32.2282 5.65895V9.01863C30.4604 8.79601 29.3192 9.63529 28.2028 11.1168V19.6529H24.6672V5.65895Z"
fill="#FF5F02"
/>
<path
d="M36.6316 19.8218C34.1303 19.8218 32.1437 18.3096 32.1437 15.1751C32.1437 12.6009 33.7201 10.8379 37.2557 10.8379H40.3288V10.4183C40.3288 9.13121 39.5406 8.59898 37.5814 8.59898C36.276 8.59898 35.2417 8.73972 33.827 9.15936V5.88412C34.916 5.57706 36.276 5.38004 37.8797 5.38004C41.9599 5.38004 43.8619 6.97416 43.8619 10.4183V19.6555H40.4084V18.8443L39.6202 19.1795C38.6132 19.5992 37.5814 19.8244 36.6291 19.8244L36.6316 19.8218ZM38.5635 16.5466L40.3313 15.7636V13.6935H37.6386C36.4153 13.6935 35.6793 14.282 35.6793 15.2058C35.6793 16.2984 36.4128 16.828 37.3377 16.828C37.7181 16.828 38.1532 16.7154 38.561 16.5491L38.5635 16.5466Z"
fill="#FF5F02"
/>
<path
d="M56.3758 19.6555V18.7318L56.1868 18.8162C54.9362 19.4329 53.6035 19.7399 52.3255 19.7399C48.9267 19.7399 45.9331 17.4728 45.9331 12.6598C45.9331 7.8467 48.9242 5.55148 52.3529 5.55148C53.6035 5.55148 54.9362 5.85853 56.1868 6.4752L56.2962 6.53149V0.341797H59.8318V19.6555H56.3758ZM52.9769 16.3802C53.7378 16.3802 54.5806 16.1832 55.4509 15.7636L56.2938 15.3439V9.97049L55.4509 9.55085C54.5806 9.13121 53.7378 8.93419 52.9769 8.93419C51.0177 8.93419 49.5507 10.1931 49.5507 12.6572C49.5507 15.1213 51.0202 16.3802 52.9769 16.3802Z"
fill="#FF5F02"
/>
<path
d="M66.2218 19.8218C63.7205 19.8218 61.7339 18.3096 61.7339 15.1751C61.7339 12.6009 63.3103 10.8379 66.8459 10.8379H69.919V10.4183C69.919 9.13121 69.1308 8.59898 67.1716 8.59898C65.8662 8.59898 64.8319 8.73972 63.4172 9.15936V5.88412C64.5062 5.57706 65.8662 5.38004 67.4699 5.38004C71.5501 5.38004 73.4521 6.97416 73.4521 10.4183V19.6555H69.9986V18.8443L69.2104 19.1795C68.2034 19.5992 67.1716 19.8244 66.2193 19.8244L66.2218 19.8218ZM68.1537 16.5466L69.9215 15.7636V13.6935H67.2288C66.0055 13.6935 65.2695 14.282 65.2695 15.2058C65.2695 16.2984 66.003 16.828 66.9279 16.828C67.3083 16.828 67.7435 16.7154 68.1512 16.5491L68.1537 16.5466Z"
fill="#FF5F02"
/>
<path
d="M76.0653 2.30182H79.6009V5.6615H83.5443V8.88045H79.6009V14.5072C79.6009 15.9632 80.3344 16.4391 81.3687 16.4391H83.5443V19.658H81.3687C77.7511 19.658 76.0653 18.0358 76.0653 14.5072V2.30182Z"
fill="#FF5F02"
/>
<path
d="M89.2555 19.8218C86.7542 19.8218 84.7676 18.3096 84.7676 15.1751C84.7676 12.6009 86.3439 10.8379 89.8795 10.8379H92.9527V10.4183C92.9527 9.13121 92.1645 8.59898 90.2053 8.59898C88.8999 8.59898 87.8656 8.73972 86.4509 9.15936V5.88412C87.5399 5.57706 88.8999 5.38004 90.5036 5.38004C94.5837 5.38004 96.4858 6.97416 96.4858 10.4183V19.6555H93.0323V18.8443L92.2441 19.1795C91.2371 19.5992 90.2053 19.8244 89.253 19.8244L89.2555 19.8218ZM91.1874 16.5466L92.9552 15.7636V13.6935H90.2624C89.0392 13.6935 88.3032 14.282 88.3032 15.2058C88.3032 16.2984 89.0367 16.828 89.9616 16.828C90.342 16.828 90.7771 16.7154 91.1849 16.5491L91.1874 16.5466Z"
fill="#FF5F02"
/>
<path
d="M98.5296 18.0588C98.5296 16.9943 99.3451 16.1551 100.407 16.1551C101.468 16.1551 102.284 16.9943 102.284 18.0588C102.284 19.1233 101.441 19.9907 100.407 19.9907C99.3725 19.9907 98.5296 19.1233 98.5296 18.0588Z"
fill="#FF5F02"
/>
</svg>

Expand Down Expand Up @@ -121,94 +112,72 @@
</cv-nav-list-item>
</cv-list>

<cv-list class="navigation-rail" slot="user-menu" activatable>
<cv-nav-list-item
class="beta-list-item"
graphic="icon"
twoline
activated
>
<svg
slot="graphic"
style="fill: orange; height: 20px"
width="100%"
height="100%"
preserveAspectRatio="xMidYMid meet"
focusable="false"
>
<g>
<path
d="M0 2C0 0.895431 0.895431 0 2 0H40L34.9206 20H2C0.895429 20 0 19.1046 0 18V2Z"
></path>
<path
d="M5.73242 14V6.8418H8.41797C8.96484 6.8418 9.40267 6.91504 9.73145 7.06152C10.0635 7.20475 10.3223 7.42773 10.5078 7.73047C10.6966 8.02995 10.791 8.34408 10.791 8.67285C10.791 8.97884 10.708 9.26693 10.542 9.53711C10.376 9.80729 10.1253 10.0254 9.79004 10.1914C10.223 10.3184 10.555 10.5348 10.7861 10.8408C11.0205 11.1468 11.1377 11.5081 11.1377 11.9248C11.1377 12.2601 11.0661 12.5726 10.9229 12.8623C10.7829 13.1488 10.6087 13.3701 10.4004 13.5264C10.1921 13.6826 9.93001 13.8014 9.61426 13.8828C9.30176 13.9609 8.91764 14 8.46191 14H5.73242ZM6.67969 9.84961H8.22754C8.64746 9.84961 8.94857 9.82194 9.13086 9.7666C9.37174 9.69499 9.55241 9.57617 9.67285 9.41016C9.79655 9.24414 9.8584 9.03581 9.8584 8.78516C9.8584 8.54753 9.80143 8.33919 9.6875 8.16016C9.57357 7.97786 9.41081 7.85417 9.19922 7.78906C8.98763 7.7207 8.62467 7.68652 8.11035 7.68652H6.67969V9.84961ZM6.67969 13.1553H8.46191C8.7679 13.1553 8.98275 13.1439 9.10645 13.1211C9.32454 13.082 9.50684 13.0169 9.65332 12.9258C9.7998 12.8346 9.92025 12.7028 10.0146 12.5303C10.109 12.3545 10.1562 12.1527 10.1562 11.9248C10.1562 11.6579 10.0879 11.4268 9.95117 11.2314C9.81445 11.0329 9.62402 10.8945 9.37988 10.8164C9.139 10.735 8.79069 10.6943 8.33496 10.6943H6.67969V13.1553ZM12.7109 14V6.8418H17.8867V7.68652H13.6582V9.87891H17.6182V10.7188H13.6582V13.1553H18.0527V14H12.7109ZM21.4326 14V7.68652H19.0742V6.8418H24.748V7.68652H22.3799V14H21.4326ZM24.4463 14L27.1953 6.8418H28.2158L31.1455 14H30.0664L29.2314 11.832H26.2383L25.4521 14H24.4463ZM26.5117 11.0605H28.9385L28.1914 9.07812C27.9635 8.47591 27.7943 7.98112 27.6836 7.59375C27.5924 8.05273 27.4639 8.50846 27.2979 8.96094L26.5117 11.0605Z"
fill="black"
fill-opacity="0.87"
></path>
</g>
</svg>
<span>You're trying console beta</span>
<span slot="secondary">Return to classic</span>
</cv-nav-list-item>
<cv-nav-list-item graphic="avatar">
<span>Notification</span>
<cv-icon slot="graphic">notifications</cv-icon>
</cv-nav-list-item>
<cv-nav-list-item graphic="avatar" class="help-item">
<span>Help</span>
<cv-icon slot="graphic">help</cv-icon>
</cv-nav-list-item>
<cv-nav-list-item graphic="avatar">
<span>Account</span>
<cv-icon slot="graphic">person</cv-icon>
</cv-nav-list-item>
</cv-list>
<cv-toolbar slot="user-menu">
<span slot="title" style="display: flex; align-items: center">
<cv-typography scale="body1">All environments</cv-typography>
<cv-icon>arrow_drop_down</cv-icon>
</span>

<cv-textfield
slot="actionItems"
icon="forum"
placeholder="Message ask.ai"
dense
></cv-textfield>
<cv-icon-button
slot="actionItems"
icon="notifications"
></cv-icon-button>
<cv-icon-button
slot="actionItems"
icon="help"
class="help-item"
></cv-icon-button>
<cv-icon-button slot="actionItems" icon="person"></cv-icon-button>
</cv-toolbar>

<div slot="help" class="mdc-typography">
<cv-toolbar>
<cv-toolbar sticky>
<span slot="title">Help</span>
<cv-icon-button
slot="actionItems"
icon="open_in_browser"
></cv-icon-button>
<cv-icon-button slot="actionItems" icon="undock"></cv-icon-button>
<cv-icon-button
slot="actionItems"
icon="close"
class="help-close"
></cv-icon-button>
</cv-toolbar>
<div style="padding: 16px">
<h3 class="mdc-typography--subtitle2">
Ultricies nunc massa, id ut felis sed varius accumsan platea.
</h3>
<p class="mdc-typography--body1">
<cv-typography scale="headline5">
Ultricies nunc massa, id ut felis sed varius accumsan platea. </cv-typography
><br />
<cv-typography scale="body1">
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam
tincidunt lectus risus, id aliquet mi congue sed.
</p>
<p class="mdc-typography--body1">
tincidunt lectus risus, id aliquet mi congue sed. </cv-typography
><br />
<cv-typography scale="body1">
Vestibulum ante ipsum primis in faucibus orci luctus et ultrices
pouere cubilia curae; Phasellus tincidunt eros arcu, sollicitudin
laoreet urna aliquet eget.
</p>
<p class="mdc-typography--body1">
laoreet urna aliquet eget. </cv-typography
><br />
<cv-typography scale="body1">
Phasellus porta sed libero vel vulputate. Quisque non nisl sem.
Pellentesque nec pretium magna, et vestibulum neque. Mauris molestie
eros quis nisi pretium,
</p>
<p class="mdc-typography--body1">
eros quis nisi pretium, </cv-typography
><br />
<cv-typography scale="body1">
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam
tincidunt lectus risus, id aliquet mi congue sed.
</p>
<p class="mdc-typography--body1">
tincidunt lectus risus, id aliquet mi congue sed. </cv-typography
><br />
<cv-typography scale="body1">
Vestibulum ante ipsum primis in faucibus orci luctus et ultrices
pouere cubilia curae; Phasellus tincidunt eros arcu, sollicitudin
laoreet urna aliquet eget.
</p>
<p class="mdc-typography--body1">
laoreet urna aliquet eget. </cv-typography
><br />
<cv-typography scale="body1">
Phasellus porta sed libero vel vulputate. Quisque non nisl sem.
Pellentesque nec pretium magna, et vestibulum neque. Mauris molestie
eros quis nisi pretium,
</p>
</cv-typography>
</div>
</div>
<div slot="mini-list">
Expand Down Expand Up @@ -278,12 +247,19 @@ <h3 class="mdc-typography--subtitle2">
>Bulk action</cv-button
>
</cv-action-ribbon>
</cv-app-shell>

<cv-menu absolute id="section-menu">
<cv-list-item>Production</cv-list-item>
<cv-list-item>Development</cv-list-item>
</cv-menu>
<cv-empty-state
headline="You don't have access to this area"
subtitle="You don't have permission to view this application.
Please contact your system administrator for further details."
icon="work"
>
<cv-button slot="buttons">Button Text</cv-button>
<cv-button slot="buttons">Button Text</cv-button>
</cv-empty-state>

<br /><br />
</cv-app-shell>

<script>
var appShell = document.querySelector('cv-app-shell');
Expand Down
Loading